JunoLab / Juno.jl

MIT License
144 stars 23 forks source link

Ctrl-C in the REPL can interrupt Juno/Atom itself #489

Closed KristofferC closed 4 years ago

KristofferC commented 4 years ago

Please search existing issues to avoid duplicates.

Details

Steps to reproduce

I press Ctrl-C in the REPL sometimes to just get a new line to type in. Sometimes when I do that I get an error message:

InterruptException:
cmp(::String, ::SubString{String}) at sys.dylib:?
== at basic.jl:294 [inlined]
#7 at eval.jl:48 [inlined]
filter(::CodeTools.var"#7#8"{SubString{String}}, ::Array{Base.PkgId,1}) at array.jl:2346
getpackage(::SubString{String}) at eval.jl:48
getsubmod(::Array{SubString{String},1}) at eval.jl:60
getmodule(::Module, ::String) at eval.jl:43
_broadcast_getindex at broadcast.jl:630 [inlined]
getindex at broadcast.jl:563 [inlined]
copyto_nonleaf!(::Array{Nothing,1}, ::Base.Broadcast.Broadcasted{Base.Broadcast.DefaultArrayStyle{1},Tuple{Base.OneTo{Int64}},typeof(CodeTools.getmodule),Tuple{Base.RefValue{Module},Base.Broadcast.Broadcasted{Base.Broadcast.DefaultArrayStyle{1},Nothing,typeof(string),Tuple{Base.Broadcast.Extruded{Array{Symbol,1},Tuple{Bool},Tuple{Int64}}}}}}, ::Base.OneTo{Int64}, ::Int64, ::Int64) at broadcast.jl:1003
copy at broadcast.jl:857 [inlined]
materialize at broadcast.jl:819 [inlined]
children(::Module) at module.jl:200
allchildren(::Module, ::Set{Module}) at module.jl:204
allchildren(::Module, ::Set{Module}) at module.jl:205
allchildren(::Module, ::Set{Module}) at module.jl:205
allchildren(::Module, ::Set{Module}) at module.jl:205
allchildren(::Module, ::Set{Module}) at module.jl:205
allchildren(::Module, ::Set{Module}) at module.jl:205
allchildren(::Module, ::Set{Module}) at module.jl:205
allchildren(::Module, ::Set{Module}) at module.jl:205
allchildren at module.jl:204 [inlined]
(::Atom.var"#112#113")() at eval.jl:42
handlemsg(::Dict{String,Any}) at comm.jl:164
(::Atom.var"#19#21"{Array{Any,1}})() at task.jl:333

So it seems like I manage to interrupt something from Atom-.jl by just Ctrl-C ing in the Atom window.

pfitzseb commented 4 years ago

Fixed on master.