search

JunoLab / Media.jl

Julia Display System
Other
5 stars 11 forks source link

@__MODULE__ is not defined on 0.6 #16

Open bjarthur opened 6 years ago

bjarthur commented 6 years ago

b0e887c15ce129548e3da7f76786e93d6e323a30 introduces a breaking change:

https://github.com/JunoLab/Media.jl/blob/master/src/system.jl#L73

bjarthur commented 6 years ago

@compat fixes this, but Media.jl does not currently REQUIRE Compat. do you plan to drop support for 0.6 or utilize compat?

bjarthur commented 6 years ago

actually, it's still broken with @compat:

julia> using Gadfly

julia> plot(y=[1])
Error showing value of type Gadfly.Plot:
ERROR: StackOverflowError:
Stacktrace:
 [1] media(::Type{T} where T) at /Users/arthurb/.julia/v0.6/Media/src/system.jl:70 (repeats 80000 times)

reverting back to current_module() fixes it. a bug in compat?

pfitzseb commented 6 years ago

I don't think we'll keep master compatible with Julia 0.6 since Juno development will switch to 0.7 in the near future and I'm not aware of any bugs that would necessitate a new Media.jl release for 0.6.

Should definitely update Media's REQUIRE file though.