search

JunoLab / Weave.jl

Scientific reports/literate programming for Julia
http://weavejl.mpastell.com
MIT License
830 stars 96 forks source link

CompatHelper: bump compat for "YAML" to "0.4" #291

Closed github-actions[bot] closed 4 years ago

github-actions[bot] commented 4 years ago

This pull request changes the compat entry for the YAML package from 0.3 to 0.3, 0.4.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

GunnarFarneback commented 4 years ago

The test dependency Gadfly is also incompatible with Compat v3, via CoupledFields.

aviatesk commented 4 years ago

Do you know why there is a compatibility problem between them ? I looked through their Project.toml files, but still not sure for that.

GunnarFarneback commented 4 years ago

Upper bounds for dependency compatibilities were added directly to the General registry at some point. Lots of packages without upper bounds in their Project files (or missing Project files entirely) thereby got the dependencies upper bounded to whatever version existed at the time. In particular Compat was at the time at 2.x, which is why many packages have an upper bound of 2 for Compat in the registry but not necessarily reflected in Project.toml.

The correct solution is in most cases to remove support for Julia versions before 1.0 and the need for Compat, then release a new version.

aviatesk commented 4 years ago

@GunnarFarneback thanks for your explanation, that makes sense. it turns out that #294 followed your idea after all.