search

JunoLab / Weave.jl

Scientific reports/literate programming for Julia
http://weavejl.mpastell.com
MIT License
824 stars 95 forks source link

use pandoc_jll #375

Open aviatesk opened 4 years ago

aviatesk commented 4 years ago

closes #343

currently this is unfunctional, seemingly because of error in pandoc_jll side. (upstream issue: https://github.com/JuliaBinaryWrappers/pandoc_jll.jl/issues/1)

codecov-commenter commented 4 years ago

Codecov Report

Merging #375 into master will increase coverage by 2.56%. The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
+ Coverage   71.71%   74.27%   +2.56%     
==========================================
  Files          25       25              
  Lines        1248     1244       -4     
==========================================
+ Hits          895      924      +29     
+ Misses        353      320      -33
Flag Coverage Δ
#unittests 74.27% <87.50%> (+2.56%) :arrow_up:
Impacted Files Coverage Δ
src/writer/pandoc.jl 57.89% <85.71%> (+57.89%) :arrow_up:
src/rendering/htmlformats.jl 90.74% <100.00%> (+8.92%) :arrow_up:
src/run.jl 81.35% <0.00%> (+1.27%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d8eca00...24d7dcf. Read the comment docs.

rikhuijzer commented 3 years ago

You can also use pandoc_crossref and Tectonic via Yggdrasil. I'm using both in https://github.com/rikhuijzer/Books.jl/blob/main/src/build.jl and they work fine. Feel free to copy code.

TheCedarPrince commented 2 years ago

Hey @pfitzseb - following up from a Slack discussion, what can I do to carry this to be successfully merged into Weave? Is this still of interest? I would love to see this merged as I think it would be great for the ecosystem.

pfitzseb commented 2 years ago

I'd recommend opening a PR against this branch that fixes CI (not sure whether pandoc_jll or Tectonic is the better choice though).