JonasIsensee commented 4 years ago

Similar to #379 except it is now based on the new master branch.

A net reduction in lines of code while adding functionality. ;)

This PR also fixes an issue in the latex formats where unicode was not escaped in output chunks. (Something similar should be done for Pandoc since it reports

julia> weave("FIR_design.jmd"; doctype="pandoc2pdf", cache=:refresh, keep_unicode=false)
[WARNING] Missing character: There is no π (U+03C0) in font [lmmono12-regular]:!
[WARNING] Missing character: There is no ⋮ (U+22EE) in font [lmmono12-regular]:!
[WARNING] Missing character: There is no ⋮ (U+22EE) in font [lmmono12-regular]:!
[ Info: Weaved to /home/jonas/.julia/dev/Weave/examples/FIR_design.pdf
"/home/jonas/.julia/dev/Weave/examples/FIR_design.pdf"

aviatesk commented 4 years ago

@JonasIsensee thanks for your PR again, and this certainly looks so great, thanks for your suggestion ! I will make sure I will review on this until weekend.

codecov-commenter commented 3 years ago

Codecov Report

Merging #380 into master will decrease coverage by 0.68%. The diff coverage is 12.50%.

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
- Coverage   74.47%   73.79%   -0.69%     
==========================================
  Files          25       26       +1     
  Lines        1332     1347      +15     
==========================================
+ Hits          992      994       +2     
- Misses        340      353      +13

Flag	Coverage Δ
#unittests	`73.79% <12.50%> (-0.69%)`	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/rendering/htmlformats.jl	`84.48% <ø> (+1.43%)`	:arrow_up:
src/rendering/pandocformats.jl	`85.18% <ø> (ø)`
src/rendering/rendering.jl	`87.50% <ø> (ø)`
src/writer/latex.jl	`0.00% <0.00%> (ø)`
src/rendering/texformats.jl	`84.90% <11.11%> (-1.64%)`	:arrow_down:
src/rendering/exportformat.jl	`14.28% <14.28%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 196d4ca...e02d5ce. Read the comment docs.

aviatesk commented 3 years ago

@JonasIsensee well, are you still interested in this project ? I would like to give you an write access for this repository if you want :)

JonasIsensee commented 3 years ago

@aviatesk

Thank you for your trust! My work and thus the tools I need have changed a little since June and so - right now - I can't use Weave anymore. (But that could just as well change again in a few months)

I did familiarize myself with a significant part of the code base for the last few PRs so I'd be happy to help with discussion and review.

What I'm trying to say: I'll happily accept write access but in the immediate future I will not use it to actively develop.

JunoLab / Weave.jl

Export formats as wrapper #380

Codecov Report