JunoLab / Weave.jl

Scientific reports/literate programming for Julia
http://weavejl.mpastell.com
MIT License
823 stars 94 forks source link

Fix for out_path only working for directories #413

Closed pgunnink closed 3 years ago

pgunnink commented 3 years ago

Now out_path creates the right file, see #383. All tests but 3 pass, but those were not working before on my system. All behavior should thus be the same.

pgunnink commented 3 years ago

I now see that the Julia formatter has changed all the formatting in the Weave.jl file, but I am not sure how to fix that... I'll look into it later if that is a problem.

aviatesk commented 3 years ago

Can you please remove the changes made by formatter ? I'd like to keep the style consistent with the other parts of code base (especially whitespaces around kwargs)

pgunnink commented 3 years ago

Sure thing, formatting should now be correct.

aviatesk commented 3 years ago

Thanks for your contribution !