search

JunoLab / Weave.jl

Scientific reports/literate programming for Julia
http://weavejl.mpastell.com
MIT License
821 stars 94 forks source link

Suport for Makie Plots [FR] #447

Closed bradcarman closed 2 years ago

bradcarman commented 2 years ago

I have coded up the necessary parts to Weave Makie plots. Unfortunately I've never done a pull request before, not sure where to start. I can drop the code here, or with some help I can create a proper pull request.

For the most part the code is straight forward, but I do see one potential issue: the capture_output(code, mod, path, error, report) function needs to call display(report, obj) rather than just display(obj). For some reason, if the obj is a Makie.Figure, it get's somehow mangled and converted to a Makie.Scene on the way to calling display(report, obj). Is there any consequence to calling the former rather than the later?

bradcarman commented 2 years ago

OK, I'm not sure why I thought this was needed, it seems that Makie is working just fine with Weave. I'll go ahead and close this.