search

JunoLab / atom-ink

IDE toolkit for Atom
MIT License
228 stars 40 forks source link

fixed typo in keymaps.cson: shift-space unset! #102

Closed mnewt closed 7 years ago

mnewt commented 7 years ago

Pretty sure !unset should be unset!. Reference commit 2ccdd863dcb460c33f7ce55a672c97b556a819f2

pfitzseb commented 7 years ago

Right you are (doesn't seem to matter too much though -- !unset means shift-space does nothing, while unset! will insert a spcae on shift-space). Thanks for the fix!

mnewt commented 7 years ago

Thanks for merging.

It does matter to me because !unset ends up being a noop rather than unset! actually removing the binding. When it's a noop it means that pressing shift-space does nothing, as opposed to the expected insertion of a space.

I type shift-space frequently right after a previous character that needs a space--like when typing 1 + 1 in the console I might drag the shift key when typing the second space. Then a space wouldn't be inserted at all. This issue bugged me while using proto-repl.

Cheers and thanks for the awesome project. Atom is turning into an amazing IDE.

pfitzseb commented 7 years ago

Right, fair enough. Glad you're enjoing ink! :)