search

JunoLab / atom-ink

IDE toolkit for Atom
MIT License
228 stars 40 forks source link

Evaluation results overlay minimap #103

Closed staticfloat closed 7 years ago

staticfloat commented 7 years ago

Large evaluation results overlay a minimap on the right.

screen shot 2016-12-15 at 11 57 51 am
pfitzseb commented 7 years ago

You can fix that by including

atom-text-editor::shadow  atom-text-editor-minimap { // `::shadow` will be unnecessary for Atom >= 1.13
  z-index: 5;
}

in your styles.less stylesheet. atom-minimap doesn't define any z-index for itself though, and our overlays have to -- so unless we were to add the above defintion (which feels wrong to me), there's no way for ink to really solve this.

staticfloat commented 7 years ago

Is this something that I could reasonably open an issue on the minimap repo about?

pfitzseb commented 7 years ago

Imho it makes sense for the minimap to have a z-index: 2 or similar (not higher than that though, because then it'd be above the scrollbars -- ink's overlays probably should be z-index: 1). Not sure if that would break anything though.

staticfloat commented 7 years ago

I'll go see if they're interested in doing that then. Thanks!

staticfloat commented 7 years ago

Actually, looking at what your fix looks like, it appears that the minimap does not have a solid background, so I'm not sure this fix actually makes anything better. ;)

screen shot 2016-12-15 at 12 29 29 pm

I think I prefer the original behavior. :)

pfitzseb commented 7 years ago

Heh, okay ;) I have absolute-mode for the minimap activated anyways, so it fits in nicely if the overlays are behind the (transparent) minimap, just like the code.