search

JunoLab / atom-ink

IDE toolkit for Atom
MIT License
229 stars 40 forks source link

inline results can cover executed code #107

Closed carocad closed 7 years ago

carocad commented 7 years ago

While using proto-repl I noticed that if I have a right pane and I evaluate something inline there, the inline atom-ink result would use all the space necessary for its display. This can get quite annoying if you evaluate lots of stuff inline since you lose sigh of the code that you executed.

A picture is better than a thousand words ;)

captura de pantalla de 2016-12-22 15-57-18

As you can see on line 13 and 14 of the right pane, the inline result is covering the code that I used to evaluate it. On line 4 on the other hand everything is fine since it has enough space to display the result.

Atom: 1.9.8 Ink: 0.6.2

pfitzseb commented 7 years ago

I think this should be fixed by https://github.com/atom/atom/pull/11852, haven't tried it yet though.

pfitzseb commented 7 years ago

Yes, this does indeed work as expected in 1.14! 🎉

carocad commented 7 years ago

@pfitzseb I assume that I would need an atom dev version to test those changes right? because at least in my atom version it doesnt work :(

pfitzseb commented 7 years ago

Yeah, 1.14 isn't released yet -- you can just clone atom and build it yourself with something like node script/build --build-dir=out --no-install.

MikeInnes commented 7 years ago

1.14 is out so this is fixed. Still some issues around inline results but we'll keep pushing on those.