search

JunoLab / atom-ink

IDE toolkit for Atom
MIT License
228 stars 40 forks source link

turn off css animations #159

Closed pfitzseb closed 6 years ago

pfitzseb commented 6 years ago

This turns off the spinning cog for in-editor results as well as the animation for indeterminate progress bars on certain themes. Seems to completely elimnate any performance issues Juno might have locally and doesn't look that bad at all, imho.

If anyone has better ideas that don't look horrible, I'm all ears :)

Fixes #142.

MikeInnes commented 6 years ago

How about replacing the animations with animated gifs? I'm not sure why the existing animations should every be resource heavy, but I'm guessing a bitmap would be better.

pfitzseb commented 6 years ago

Yeah, we can do that for the inline results, but not for the progress bar. I'll take a look.

MikeInnes commented 6 years ago

Why not? Just because of styling?

pfitzseb commented 6 years ago

Huh, so I tried replacing the spinner with an animated svg -- still takes ~20% CPU load (for one result) on my machine, as opposed to <2% without any animations at all.