search

JunoLab / atom-ink

IDE toolkit for Atom
MIT License
228 stars 40 forks source link

Add optional argument for `goto` function to enable pending #208

Closed aviatesk closed 4 years ago

aviatesk commented 4 years ago

This is just a suggestion, please feel free to close this if you guys don't like it.

IMO within julia-client's goto feature, pending open seems to be better to keep opened editors clean, and the closed editors can be easily restored by Julia-Client: Return-From-Goto.

Update

I approach this by making opts optional arguments to goto function so that the consumer package (atom-julia-client) can pass the option for pending opening.

The corresponding PR on atom-julia-client side is: https://github.com/JunoLab/atom-julia-client/pull/579

pfitzseb commented 4 years ago

Thanks!