search

JunoLab / atom-ink

IDE toolkit for Atom
MIT License
228 stars 40 forks source link

Add support for underline results #21

Closed pfitzseb closed 8 years ago

pfitzseb commented 8 years ago

This adds support for underline results (which aren't even implemented in Atom yet, but whatever). For now, these are just some methods that add a normal decoration, but once https://github.com/atom/atom/pull/9930 lands, we can switch to those.

sglyon commented 8 years ago

Looks cool!

When will we underline things?

pfitzseb commented 8 years ago

Ah, I messed up the link. Once this is in stable Atom, we can use it and have Julia/LT-like docs :)

sglyon commented 8 years ago

I'm not much of a css expert, so I'll defer to others for a more helpful review

pfitzseb commented 8 years ago

The css stuff is pretty much copied from above and more of a placeholder -- certainly not very pretty, but functional.

MikeInnes commented 8 years ago

Nice one. I think it would be good to wait until we have a concrete use case for this, like the inline docs stuff, to reduce the risk of code rot, but it's good to have this stuff ready and waiting.

Potentially this would be useful as a display option for plots as well.

pfitzseb commented 8 years ago

Yeah, well, the point of this is that I'd like to use it for the inline doc stuff ;) They could of course just use the normal result format, but this is slightly nicer and would provide a stable API when we switch to the block results for this.