search

JunoLab / atom-ink

IDE toolkit for Atom
MIT License
228 stars 40 forks source link

[BUG] xterm.js@4.5.0 seems to contain a bug #274

Closed aviatesk closed 4 years ago

aviatesk commented 4 years ago

When we create an new terminal, the following error happens:

CursorRenderLayer.ts:146 Uncaught TypeError: Cannot read property 'loadCell' of undefined
    at e._render (CursorRenderLayer.ts:146)
    at e.onGridChanged (CursorRenderLayer.ts:123)
    at WebglRenderer.ts:251
    at Array.forEach (<anonymous>)
    at e.renderRows (WebglRenderer.ts:250)
    at t._renderRows (RenderService.ts:96)
    at e._renderCallback (RenderService.ts:48)
    at e._innerRefresh (/Users/aviatesk/github/atom-pkgs/atom-ink/node_modules/xterm/lib/xterm.js:1)
    at RenderDebouncer.ts:52
e._render @ CursorRenderLayer.ts:146
e.onGridChanged @ CursorRenderLayer.ts:123
(anonymous) @ WebglRenderer.ts:251
e.renderRows @ WebglRenderer.ts:250
t._renderRows @ RenderService.ts:96
(anonymous) @ RenderService.ts:48
e._innerRefresh @ /Users/aviatesk/github/atom-pkgs/atom-ink/node_modules/xterm/lib/xterm.js:1
(anonymous) @ RenderDebouncer.ts:52
requestAnimationFrame (async)
e.refresh @ RenderDebouncer.ts:47
t.refreshRows @ RenderService.ts:91
t.refresh @ Terminal.ts:922
t.open @ Terminal.ts:628
e.open @ Terminal.ts:70
initialize @ view.js:26
(anonymous) @ console.js? [sm]:61
simpleDispatch @ /Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/dist/emitter.js:64
emit @ /Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/dist/emitter.js:257
didActivatePaneContainer @ /Applications/Atom.app/Contents/Resources/app.asar/src/workspace.js:503
Dock.subscriptions.CompositeDisposable.paneContainer.onDidActivatePane @ /Applications/Atom.app/Contents/Resources/app.asar/src/dock.js:66
simpleDispatch @ /Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/dist/emitter.js:64
emit @ /Applications/Atom.app/Contents/Resources/app.asar/node_modules/event-kit/dist/emitter.js:257
didActivatePane @ /Applications/Atom.app/Contents/Resources/app.asar/src/pane-container.js:313
activate @ /Applications/Atom.app/Contents/Resources/app.asar/src/pane.js:1112
open @ /Applications/Atom.app/Contents/Resources/app.asar/src/workspace.js:1214
async function (async)
open @ /Applications/Atom.app/Contents/Resources/app.asar/src/workspace.js:1160
open @ pane-item.js:140
(anonymous) @ console.js? [sm]:186
Promise.then (async)
newTerminal @ console.js? [sm]:183
juliaClientNewTerminal @ console.js? [sm]:139
handleCommandEvent @ /Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:405
module.exports.KeymapManager.dispatchCommandEvent @ /Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:617
module.exports.KeymapManager.handleKeyboardEvent @ /Applications/Atom.app/Contents/Resources/app.asar/node_modules/atom-keymap/lib/keymap-manager.js:408
handleDocumentKeyEvent @ /Applications/Atom.app/Contents/Resources/app.asar/src/window-event-handler.js:153

I thought this PR might help, but updating xterm-addon-webgl to v0.5.1 didn't help. Not sure this issue should be upstreamed.

pfitzseb commented 4 years ago

Seems to be fixed by https://github.com/JunoLab/atom-ink/pull/275.

aviatesk commented 4 years ago

nice