JunoLab / atom-ink

IDE toolkit for Atom
MIT License
228 stars 40 forks source link

Rollup #277

Open aminya opened 4 years ago

aminya commented 4 years ago

We made it 😃 Fixes https://github.com/JunoLab/atom-ink/issues/144

Now it loads 2.6X faster

reduces the ink load time by 110ms + 20ms for julia-client

After Ink rollup and Katex movement

After Ink rollup without Katex movement

Without Ink rollup

To achieve I made some changes to the code:

One difference: I used static import in ink.coffee (which bundles everything into one file). If you want I can change this to dynamic import (which makes use of Rollup's code splitting). I did not do this since I was not sure how these variables are used on the julia-client side, and using dynamic import may ruin the performance if these are called right away from the Julia client.

Registering

Similar to https://github.com/JunoLab/atom-indent-detective/issues/23

Commit history is verbose so you can review it easily.

In sync with https://github.com/JunoLab/atom-julia-client/pull/750

aminya commented 4 years ago

@pfitzseb Could you review this? If you have any questions we can have a skype call.