search

JunoLab / atom-ink

IDE toolkit for Atom
MIT License
229 stars 40 forks source link

Ink 0.4.0 messes with Atom window size #37

Closed m0nhawk closed 8 years ago

m0nhawk commented 8 years ago

After updating to Ink 0.4.0 it starts to messes with Atom window size and positioning: it position window in the (0, 0) with height of 100% of screen resolution and 50% width.

Allardvm commented 8 years ago

I also ran into this issue. Atom no longer saves the window size and position on my Mac (El Capitan) upon closing. When I disable the Ink package, everything works as expected.

pfitzseb commented 8 years ago

This is due to those lines -- no clue why this should change anything about the window size though.

Seems a bit like a bug in Atom: Similar calls involving editors, e.g. atom.workspace.getTextEditors(), change the window size as well when called in the activate function.

Possibly related: https://github.com/atom/atom/pull/9664

MikeInnes commented 8 years ago

Those lines have been there for a while, but perhaps they're interacting badly with the new deserialisation code? Either way, editors actually already have IDs, so we should just replace that code.

pfitzseb commented 8 years ago

IIRC this issue has been around for quite a while as well (at least for me, but I just never attributed it to ink).

pfitzseb commented 8 years ago

Yeah, I don't quite know why I thought those lines were the culprit -- can't reproduce the behaviour I saw when testing a few days back.

That said, I'm pretty sure this is because of those lines now -- what's the failure mode this is supposed to address, @MikeInnes? I don't see any (de)serialisation problems with the console or whatever when commenting this out, but of course I don't know what to look for anyways...