search

JunoLab / atom-ink

IDE toolkit for Atom
MIT License
228 stars 40 forks source link

next try at fixing #37 #41

Closed pfitzseb closed 8 years ago

pfitzseb commented 8 years ago

This does indeed seem to fix #37, and I can also not see any adverse side effects even though the comment indicates that those lines are there for a reason. @MikeInnes Could you try this and see whether it breaks serialisation or whatever?

MikeInnes commented 8 years ago

Basically, if a package doesn't register serialisers, that key gets set so that Atom can defer the package load next time. The key seemed to be getting set for Ink and then never unset, so after a while you'd just lose your console layout and stuff. That said I was on a weird dev setup, and there's no way we should really need this in theory, so we should just try removing it and see what happens.