search

JunoLab / atom-ink

IDE toolkit for Atom
MIT License
228 stars 40 forks source link

Custom keybindings not responding in REPL entry #75

Closed jasongilman closed 6 years ago

jasongilman commented 8 years ago

This is a copy of an issue filed in Proto REPL #161. I think this is a problem with the Atom Ink Console.

Hello. I updated today to 1.4.7 and have found some misbehavior with the text entry from the previous version I was using.

I use a Finnish keyboard, and a set of custom keybindings to rebind the ö, ä, and å keys to the braces. See here: https://gist.github.com/jarcane/468687e98176c1c4c8a7ba924dafdf46 (the use of `, \, and ] refers to the ö/ä/å keys, because Atom uses the American keymap only, internally)

Unfortunately, these keys don't work in the Proto-REPL pane, at all. It seems to simply ignore input from those keys entirely; I get no input.

I've also found that the automatic pairing of braces from Paredit isn't honored in the Proto-REPL window either, though that should perhaps be filed as a separate issue?

pfitzseb commented 7 years ago

Yeah, that's to be expected with how those commands are defined. atom.workspace.getActiveTextEditor() only works if the TextEditor is the active item in some Pane (see the implementation here) -- imo this is somewhat unfortunate behaviour and should probably be fixed in Atom core. The paredit issue probably has the same cause, but not totally sure.

The best workaround for the keybinding stuff is probably to use the keyboard-localization-package, which works great for me even in the console.