search

JunoLab / atom-ink

IDE toolkit for Atom
MIT License
228 stars 40 forks source link

Progress Refactor the Third #95

Closed MikeInnes closed 7 years ago

MikeInnes commented 7 years ago

@pfitzseb this is your code so would appreciate your take. The tooltips got sidelined by this – I tried to make an atom tooltip component for that but it’s failing (possibly due to an etch bug).

I’m also not sure we really need three separate ways to add arbitrary information to progress bars. Perhaps we can just have leftText -> description and allow arbitrary views there (including tooltips). The right can be reserved for timers and buttons.

MikeInnes commented 7 years ago

I'd be happy with strict mode but can't figure out how to get it working with 'use babel'. Perhaps there's a babel option to enable it package-wide?

If it's OK with you, I'd prefer to shelve message and rightText for now and get this in. I think we need use cases, or at least a bit more thought, for those things so that we don't risk committing to the wrong API. In the meantime I'd like to get some debugger UI work in on top of these changes.

pfitzseb commented 7 years ago

There is a plugin for that, but I don't know if having a .babelrc works for apm projects.

I think having some more description possibilites for progress bars makes sense, but I also agree that we can figure out the exact API later.

MikeInnes commented 7 years ago

Thanks – I actually just did the more sensible thing and pulled the blocking part of this out onto master :) But yeah, probably still a good idea to see how people are using this stuff before adding more features.