Closed aminya closed 4 years ago
The node-js bundled with atom is a little old, and so its ESLint version doesn't recognize @typescript-eslint plugin. I am trying to install my custom ESLint version, but I can't. I might remove online linting for TypeScript (Compiled JS files are still linted).
Edit: (Resolved) I made a custom script for that! Fixed in https://github.com/JunoLab/atom-julia-client/pull/704/commits/5baadc224e56d39e75cdae62e54fd1eaa1467dee
I use Github actions instead of Travis and Appveyor.
For some reason you can only see the running actions here: https://github.com/aminya/atom-julia-client/actions
I think you need to enable Github Actions for the master branch (or something similar). Spec doesn't run online though. Only building the package/linting is enabled in the CI.
Edit: The spec fails to load ink and language-julia. So I thought maybe it is because of the old jasmine syntax. I tried to update the tests in https://github.com/aminya/atom-julia-client/pull/3, but it is harder than it seems. So I will test each commit offline on my system before pushing.
This is closed in favor of https://github.com/JunoLab/atom-julia-client/pull/705.
It distills this PR into smaller ones.
Converting codebase to TypeScript
[ ] Compiling each ts file one by one to replace the corresponding
lib
fileHow to review?
Use commits history instead of going through the files. I keep compilation separate from editing (helps in case we wanted to edit the history). https://github.com/JunoLab/atom-julia-client/pull/704/commits
Skip reviewing map files (js.map) and declaration files (d.ts) at first. Ask me to remove them if they are distracting.
lib_src
and the compiled JS is kept inlib
I test each commit offline on my system before pushing.