Type script

[aminya]

Converting codebase to TypeScript

• [X] adding configurations
• [X] decaffeinate
• [X] js-to-ts
• [X] linting for JS, TS, Coffee
• [X] Use Github actions instead of Travis and Appveyor. See the running actions here: https://github.com/aminya/atom-julia-client/actions?query=branch%3ATypeScript

• [ ] Compiling each ts file one by one to replace the corresponding lib file

  • Using import/exports instead of requiring if possible
  • Adding type definitions
  • other ts fixes
  • tslint
  • Using atom-select-list-ts instead of space-pen-views using the similar that was made for atom-indent-detective
  • Using etch-ts instead of etch
  • Optimizing code wherever possible
  • Using TypeAssembly if worth it
  • [ ] connection\process\basic.ts
  • [ ] connection\process\boot.ts
  • [ ] connection\process\cycler.ts
  • [ ] connection\process\remote.ts
  • [ ] connection\process\server.ts
  • [ ] connection\process\tcp.ts
  • [ ] connection\client.ts
  • [ ] connection\ipc.ts
  • [ ] connection\local.ts
  • [ ] connection\messages.ts
  • [ ] connection\terminal.ts
  • [x] misc\blocks.ts
  • [x] misc\cells.ts
  • [x] misc\colors.ts
  • [ ] misc\paths.ts
  • [x] misc\scopes.ts
  • [ ] misc\weave.ts
  • [ ] misc\words.ts
  • [ ] package\commands.ts
  • [ ] package\config.ts
  • [ ] package\menu.ts
  • [ ] package\settings.ts
  • [ ] package\toolbar.ts
  • [ ] runtime\completions.ts
  • [ ] runtime\console.ts
  • [ ] runtime\datatip.ts
  • [ ] runtime\debugger.ts
  • [ ] runtime\debuginfo.ts
  • [ ] runtime\evaluation.ts
  • [ ] runtime\formatter.ts
  • [ ] runtime\frontend.ts
  • [ ] runtime\goto.ts
  • [ ] runtime\linter.ts
  • [ ] runtime\modules.ts
  • [ ] runtime\outline.ts
  • [ ] runtime\packages.ts
  • [ ] runtime\plots.ts
  • [ ] runtime\profiler.ts
  • [ ] runtime\urihandler.ts
  • [ ] runtime\workspace.ts
  • [ ] ui\cellhighlighter.ts
  • [ ] ui\docs.ts
  • [ ] ui\focusutils.ts
  • [ ] ui\highlighter.ts
  • [ ] ui\layout.ts
  • [ ] ui\notifications.ts
  • [ ] ui\progress.ts
  • [ ] ui\selector.ts
  • [ ] ui\views.ts
  • [ ] connection.ts
  • [ ] julia-client.ts
  • [ ] misc.ts
  • [ ] runtime.ts
  • [ ] ui.ts
• [ ] Merging ink and repeating the process for the ink
• [ ] Online run spec CI

How to review?

• Use commits history instead of going through the files. I keep compilation separate from editing (helps in case we wanted to edit the history). https://github.com/JunoLab/atom-julia-client/pull/704/commits

• Skip reviewing map files (js.map) and declaration files (d.ts) at first. Ask me to remove them if they are distracting.

  • Note: Source code is in lib_src and the compiled JS is kept in lib
  • Note: d.ts/map files are auto-generated (they are necessary for the final release).

• I test each commit offline on my system before pushing.

[aminya]

The node-js bundled with atom is a little old, and so its ESLint version doesn't recognize @typescript-eslint plugin. I am trying to install my custom ESLint version, but I can't. I might remove online linting for TypeScript (Compiled JS files are still linted).

Edit: (Resolved) I made a custom script for that! Fixed in https://github.com/JunoLab/atom-julia-client/pull/704/commits/5baadc224e56d39e75cdae62e54fd1eaa1467dee

[aminya]

I use Github actions instead of Travis and Appveyor.

For some reason you can only see the running actions here: https://github.com/aminya/atom-julia-client/actions

I think you need to enable Github Actions for the master branch (or something similar). Spec doesn't run online though. Only building the package/linting is enabled in the CI.

Edit: The spec fails to load ink and language-julia. So I thought maybe it is because of the old jasmine syntax. I tried to update the tests in https://github.com/aminya/atom-julia-client/pull/3, but it is harder than it seems. So I will test each commit offline on my system before pushing.

[aminya]

This is closed in favor of https://github.com/JunoLab/atom-julia-client/pull/705.

It distills this PR into smaller ones.