JunoLab / atom-julia-client

Juno a good IDE?
http://junolab.org
MIT License
273 stars 72 forks source link

Eslint + GithubActions instead of Travis/Appveyor #712

Closed aminya closed 4 years ago

aminya commented 4 years ago

P.S: no typescript config is in this PR. It's pure JS/Coffee.

pfitzseb commented 4 years ago

Why are Github Actions better than travis?

aminya commented 4 years ago

https://github.com/aminya/atom-julia-client/blob/github_actions/.github/workflows/ci.yml

aminya commented 4 years ago

This is ready to get merged now.

aminya commented 4 years ago

What's wrong with this? @aviatesk

aviatesk commented 4 years ago

sorry for closing without providing reasons, @aminya I closed since:

I'm thinking of moving julia-client's CI to use GH actions, but it would be nice if you want to keep work on this:

Let me know you want to reopen this.

aminya commented 4 years ago

The tests doesn't work locally. This isn't the problem of this PR.

aminya commented 4 years ago

Also, Eslint is configured as just warnings. It doesn't forces anything. It is possible to configure it to use Standard.

https://github.com/standard/eslint-config-standard

The standard way to do online linting is using Eslint framework. Configuration depends on the usecase.