search

JunoLab / atom-julia-client

Juno a good IDE?
http://junolab.org
MIT License
273 stars 72 forks source link

release note #725

Closed aviatesk closed 4 years ago

aviatesk commented 4 years ago

try to show release notes in a modal.

Couple of problems I couldn't solve:

Please modify this PR if you figure out the fixes, or even supercede this if you want to start from the other way.

aviatesk commented 4 years ago

switched the base branch

pfitzseb commented 4 years ago

Simplified the logic a bit and fixed the styling. Let me know what you think.

aviatesk commented 4 years ago

Simplified the logic a bit and fixed the styling. Let me know what you think.

nice, but... I'm afraid to say I'm now slightly against the modal idea; maybe some users want to see/try new features while having editor pane and release note pane, side by side ? And I guess this is why vscode shows release note as an editor pane, I dunno. Well, the modal surely has more attentions.

pfitzseb commented 4 years ago

nice, but... I'm afraid to say I'm now slightly against the modal idea; maybe some users want to see/try new features while having editor pane and release note pane, side by side ?

I tend to agree :)

aviatesk commented 4 years ago

okay I reverted back to the previous idea. Now this PR needs https://github.com/JunoLab/atom-ink/pull/270.