Closed aviatesk closed 4 years ago
switched the base branch
Simplified the logic a bit and fixed the styling. Let me know what you think.
Simplified the logic a bit and fixed the styling. Let me know what you think.
nice, but... I'm afraid to say I'm now slightly against the modal idea; maybe some users want to see/try new features while having editor pane and release note pane, side by side ? And I guess this is why vscode shows release note as an editor pane, I dunno. Well, the modal surely has more attentions.
nice, but... I'm afraid to say I'm now slightly against the modal idea; maybe some users want to see/try new features while having editor pane and release note pane, side by side ?
I tend to agree :)
okay I reverted back to the previous idea. Now this PR needs https://github.com/JunoLab/atom-ink/pull/270.
try to show release notes in a modal.
Couple of problems I couldn't solve:
Please modify this PR if you figure out the fixes, or even supercede this if you want to start from the other way.