JunoLab / atom-julia-client

Juno a good IDE?
http://junolab.org
MIT License
273 stars 72 forks source link

Improved handling of paths with spaces in the REPL (Win, macOS, Linux) #734

Closed FAlobaid closed 4 years ago

FAlobaid commented 4 years ago

This fix is related to JunoLab/Juno.jl#421 and improves on the previous PR JunoLab/atom-julia-client#731 to better handle paths with spaces in the REPL for Windows, macOS and Linux. Among other things, it correctly handles extension-less files and newline. However, it doesn't fully match the following (so avoid):

1- If you start with a folder name with spaces (obviously). See example 1 in the avoid section. 2- If you have extension-less filename with spaces. See examples 2 and 3 in the avoid section. 3- If you have file extension with spaces. See examples 4 and 5 in the avoid section.

Related PR: JunoLab/Atom.jl#322

Examples for Windows: win_js

Examples for macOS / Linux: nix_js

FAlobaid commented 4 years ago

thanks for your help and sorry for late review

Most welcome and thanks for all your efforts :+1: