search

JunoLab / atom-julia-client

Juno a good IDE?
http://junolab.org
MIT License
273 stars 72 forks source link

recover OS notification #736

Open aviatesk opened 4 years ago

aviatesk commented 4 years ago

OS notifications is still an issue ? Searching in atom repo, there seems to be a problem in tree-view stuff in electron<4 on macOS, but couldn't find an issue related to OS notification.

pfitzseb commented 4 years ago

https://github.com/electron/electron/issues/18701 is the upstream issue -- seems like it's only been fixed very recently and I don't think the new Electron version has propagated to Atom yet.

aviatesk commented 4 years ago

okay. Well, do you think we can disable close only on macOS ? I found notifications are swept away after few seconds anyway, so I guess we actually don't need close calls from the beginning, no ?

I started to use Juno for tasks including time consuming computation, and I found I really want this OS notification.

(P.S. I also really can't reproduce the crash on my macOS Mojave 10.14.6 even when calling closes...)

pfitzseb commented 4 years ago

It's probably fine to re-enable this fi we can test it on all platforms and keep it behind a setting.