JunoLab / atom-latex-completions

Easy Unicode input for Atom
MIT License
40 stars 7 forks source link

Exclude lower priority #5

Closed MikeInnes closed 8 years ago

MikeInnes commented 8 years ago

In theory the higher priority of latex-completions should put it above julia-client completions, but that doesn't seem to be happening, so I'm just excluding julia-client's provider completely while latex-completions is active.

This kills a few of birds with one stone, including the shadowing problem of #4 and the problem of having to scroll down to find latex completions. cc @Varanas

pfitzseb commented 8 years ago

While this totally makes sense, it also seems to kill the default julia autocompletions for me, e.g. zer<tab> doesn't display anything.

MikeInnes commented 8 years ago

Ah, whoops. Let's see if there's a way to mark latex-completions as being inactive.

pfitzseb commented 8 years ago

Couldn't find anything regarding deactivating a provider, but a ref to filtering completions on text: https://github.com/atom/autocomplete-plus/issues/615

MikeInnes commented 8 years ago

Success! Turns out inclusionPriority wasn't meant to do what I thought at all; providers are prioritised by specificity, but this can be overridden by this hidden option.

pfitzseb commented 8 years ago

Looking good!

sglyon commented 8 years ago

Yes! This is great