Closed gerbrent closed 2 years ago
Could relate to https://github.com/JupiterBroadcasting/jupiterbroadcasting.com/issues/72#issuecomment-1179765579 and thus #75
So, I haven't gotten to work on #110 yet, but when I do I'll try and also take a look at this. There is probably an easier solution in the code we could do, like have an aliases
or nicknames
field which accepts all those variations. Then we could always identify that person in the future as well in case their url name (slug) changed again.
That's just off the top of my head though, I've got to look at the code to find out if it's possible.
It actually looks like @kbondarev did some map for host already (probably for something else, but that means there is mapping logic in there :upside_down_face: ), we'll probably be able to do something like I was mentioning above then :grin:
It actually looks like @kbondarev did some map for host already (probably for something else, but that means there is mapping logic in there upside_down_face ), we'll probably be able to do something like I was mentioning above then grin
Yes, that map is used for exactly that. Will need to identify all the guests with with multiple usernames/stubs and add them all to that map.
@gerbrent
The actual content of the files should be consolidated. This should still be done here in #75 as described in here
In terms of the show-scraper:
usernames_map
described above. I added more items to it, see here.make sure the scraper wont simply recreate them
I added a data_dont_override
list in the config file. Any data file (sponsor or people) that has been "consolidated" or modified manually should be added to that list. The scraper will not override these files!
Edit: I messed a few things up with #202 and #203 fixed it all.
Some Guests are listed multiple times, due perhaps to different stubs used in various Fireside listings.
Examples:
Danielle Foré
Drew DeVore
Jim Salter
Philip Müller
Stuart Langridge
We should: