JupiterBroadcasting / jupiterbroadcasting.com

JupiterBroadcasting.com, hugo-based and community-driven!
https://jupiterbroadcasting.com
102 stars 49 forks source link

guests - some listed multiple times w different stubs #158

Closed gerbrent closed 2 years ago

gerbrent commented 2 years ago

Some Guests are listed multiple times, due perhaps to different stubs used in various Fireside listings.

Examples:

We should:

gerbrent commented 2 years ago

Could relate to https://github.com/JupiterBroadcasting/jupiterbroadcasting.com/issues/72#issuecomment-1179765579 and thus #75

elreydetoda commented 2 years ago

So, I haven't gotten to work on #110 yet, but when I do I'll try and also take a look at this. There is probably an easier solution in the code we could do, like have an aliases or nicknames field which accepts all those variations. Then we could always identify that person in the future as well in case their url name (slug) changed again.

That's just off the top of my head though, I've got to look at the code to find out if it's possible.

elreydetoda commented 2 years ago

It actually looks like @kbondarev did some map for host already (probably for something else, but that means there is mapping logic in there :upside_down_face: ), we'll probably be able to do something like I was mentioning above then :grin:

https://github.com/JupiterBroadcasting/show-scraper/blob/9adc48d71962b5642f4d2c641d9409454e018383/config.yml#L39

kbondarev commented 2 years ago

It actually looks like @kbondarev did some map for host already (probably for something else, but that means there is mapping logic in there upside_down_face ), we'll probably be able to do something like I was mentioning above then grin

https://github.com/JupiterBroadcasting/show-scraper/blob/9adc48d71962b5642f4d2c641d9409454e018383/config.yml#L39

Yes, that map is used for exactly that. Will need to identify all the guests with with multiple usernames/stubs and add them all to that map.

kbondarev commented 2 years ago

@gerbrent


Edit: I messed a few things up with #202 and #203 fixed it all.