search

JupiterOne / starbase

Graph-based security analysis for everyone
Mozilla Public License 2.0
337 stars 32 forks source link

Add 'jupiterone' storage engine #79

Closed erichs closed 2 years ago

erichs commented 2 years ago

Add JupiterOneStorageEngine config type Write dotenv file for jupiterone storage engine Refactor config.storage to StarbaseStorage[] Support multiple storage backends, if configured Update Changelog

Implements #60

erichs commented 2 years ago

NOTE: this PR does not address instanceId validation or support integration API tokens. Additionally, it introduces very minor buggy behavior when running starbase locally several times--the .env file will accumulate values.

These sharp edges will be filed off in future PRs.

adam-in-ict commented 2 years ago

Thanks for the PR! Looks great! I had one comment on the handling of the apiBaseUrl configuration value, but other than that, I think it's ready for approval.

I'd recommend we tag this as a major revision change due to it being a breaking change for anyone using the current storage configuration yaml format that doesn't list them in an array.

erichs commented 2 years ago

So... technically, a major version bump here would put us at 1.0.0, which I don't think communicates what we want here. Pre-1.0, all non-patch changes should be considered breaking anyway, so I vote for a minor bump.

j1-internal-automation commented 2 years ago

:rocket: PR was released in v0.5.0 :rocket: