JupiterOne / starbase

Graph-based security analysis for everyone
Mozilla Public License 2.0
337 stars 32 forks source link

Add Memgraph support #99

Open matea16 opened 1 year ago

matea16 commented 1 year ago

Hi, I'm Matea, Memgraph's Developer Experience team member. Recently I've been deep diving into your amazing Starbase project and decided to enhance its compatibility with Memgraph. I adjusted a few files and queries in order for them to work with Memgraph, and ensured seamless integration.

I've also taken the initiative to create a pull request for the integration of Memgraph's SDK CLI for full compatibility. Looking forward to your feedback!

adam-in-ict commented 1 year ago

Thanks so much for the contribution!

I'm assuming based on my initial look at the PR that we'll want to complete the SDK contribution first to expose the additional memgraph commands, but I went ahead and put in a few small comments here. I'll go have a look at the SDK PR here shortly.

Thanks!

matea16 commented 1 year ago

So sorry for the late response. I've added another commit where I agree with your comments and fixed stuff mentioned. Feel free to let me know if there's something else you noticed, thank you! I'll also get to the sdk PR asap :)