search

Jupyter-contrib / jupyter_nbextensions_configurator

A jupyter notebook serverextension providing config interfaces for nbextensions.
Other
981 stars 121 forks source link

Support nbclassic while updating the static path #141

Closed echarles closed 2 years ago

echarles commented 2 years ago

Fixes https://github.com/jupyter/nbclassic/issues/140

This PR ensure that jupyter_nbextensions_configurator can also run on the latest nbclassic.

echarles commented 2 years ago

While this works fine when the user clicks on the menu to show the configurator page (http://localhost:8888/tree?#nbextensions_configurator), it does not solve the issue when the user directly types in his browser http://localhost:8888/nbextensions

This can however be merged as a step towards a more complete solution.

echarles commented 2 years ago

This PR is ready for review.

kevingoldsmith commented 2 years ago

LGTM

echarles commented 2 years ago

@juhasch Have you bandwidth to review and help with this? Anyone else interested to have a look? Thx!

echarles commented 2 years ago

I am adding @damianavila as potential reviewer of this PR (just seeing Damian is part of this jupyter-contrib github organisation).

Happy to answer any question on these changes which are fully backwards compatible.

damianavila commented 2 years ago

@juhasch would be a better reviewer than me since I have not been connected with the codebase for a loooong time.

Juergen, WDYT about this one? I presume this one would also need a release as well...

echarles commented 2 years ago

Thx @damianavila for the comment.

@juhasch Do you have any question on this change. It is working fine on my env for notebook 6.4.x, 6.5.x and nbclassic.

juhasch commented 2 years ago

Sorry for replying so late, I am mostly off Github currently. Let me take a look what to do.

juhasch commented 2 years ago

Thank you for your patience @echarles

echarles commented 2 years ago

Super! Thx you for taking time to review and merge @juhasch

I wonder what are the plans for a release? Would you like me to open an issue for that?

juhasch commented 2 years ago

We should do a release quickly, I think. If you open a PR that would be great.

echarles commented 2 years ago

We should do a release quickly, I think. If you open a PR that would be great.

I am not sure what content the PR should have. Do I have to just bump the version?

juhasch commented 2 years ago

Just bump the version and update the readme (changes section). That should be enough.

echarles commented 2 years ago

Thx @juhasch. I have opened https://github.com/Jupyter-contrib/jupyter_nbextensions_configurator/pull/143/files for that.

damianavila commented 2 years ago

Folks, created https://github.com/Jupyter-contrib/jupyter_nbextensions_configurator/issues/146 to further discuss adding more maintainers to this project.