Jupyter-contrib / jupyter_nbextensions_configurator

A jupyter notebook serverextension providing config interfaces for nbextensions.
Other
981 stars 121 forks source link

nbclassic >=0.5 breaks jupyter_nbextensions_configurator #151

Closed scmmmh closed 1 year ago

scmmmh commented 1 year ago

Hi,

It seems that the nbclassic >= 0.5 releases break the jupyter_nbextensions_configurator extension, because it cannot find the corrected "marked.js" file. It is trying to load "/static/nbclassic/components/marked/lib/marked.js?v=20230228105802", but cannot find that. If I pin nbclassic < 0.5, then it works.

Migrated from https://github.com/jupyter/nbclassic/issues/227.

Best, Mark

ego commented 1 year ago

I have the same problem

Screenshot 2023-02-28 at 17 05 23
pip install "nbclassic<0.5"

downgrade fix the issue

mforbes commented 1 year ago

This is quite problematic for new users. Could a quick release to PyPI pinning nbclassic<0.5 please be made until support for the upgraded marked is provided? (Looks like this is almost done? https://github.com/Jupyter-contrib/jupyter_nbextensions_configurator/pull/152).

echarles commented 1 year ago

This is quite problematic for new users. Could a quick release to PyPI pinning nbclassic<0.5 please be made until support for the upgraded marked is provided? (Looks like this is almost done? https://github.com/Jupyter-contrib/jupyter_nbextensions_configurator/pull/152).

@juhasch What are your thoughts on this. Should we have a PR that pins to nbclassic<0.5, make a release, and then only after merge https://github.com/Jupyter-contrib/jupyter_nbextensions_configurator/pull/152 and make the release?

echarles commented 1 year ago

nbclassic 0.5.4 is released and should fix this issue. Can anyone confirm and close this?

paulhybryant commented 1 year ago

No, I have nbclass 0.5.4 installed, and I am still getting this error.

main.js?v=20230407171327:1001 

       [jupyter_nbextensions_configurator] error loading zenmode/main:
TypeError: marked is not a function
build_extension_ui @ main.js?v=20230407171327:1001
render.js?v=20230407171327:155 

       Uncaught TypeError: marked is not a function
    at Object.render_markdown (render.js?v=20230407171327:155:13)
    at Object.success (main.js?v=20230407171327:582:26)
    at c (jquery.min.js:2:1)
    at Object.fireWith [as resolveWith] (jquery.min.js:2:1)
    at l (jquery.min.js:2:1)
    at XMLHttpRequest.<anonymous> (jquery.min.js:2:1)
echarles commented 1 year ago

Thx for reporting @paulhybryant. I have tested in a blank env and the configurator works fine for some of the extensions, but indeed fails for the zenmode - see screenshots below. I would say this is due to an upgrade of zenmode, but is not managed by nbclassic, nor by the configurator extension. The best would be that you open an issue on the zenmode repo.

Screenshot 2023-04-07 at 11 53 09 Screenshot 2023-04-07 at 11 52 54 Screenshot 2023-04-07 at 11 52 57 Screenshot 2023-04-07 at 11 53 30
xiphl commented 1 year ago

Hi, I am seeing the same error message as @paulhybryant in the configurator menu (with nbclassic 0.5.4) when i load the page using browser dev tools. Although the extensions are generally working (ie I activated ExecuteTime using the checkboxes and observed that the notebook did show the execute timing), the README part for each extensions are not showing up (see screenshot), does anyone have any suggestions on how to solve it? image For all the extensions, I observed the same error message: [jupyter_nbextensions_configurator] error loading <any-extension-in-the-list>/main: TypeError: marked is not a function build_extension_ui @ main.js?v=20230410094859:1001 open_ext_ui @ main.js?v=20230410094859:682 selector_nav_link_callback @ main.js?v=20230410094859:715 dispatch @ jquery.min.js:2 v.handle @ jquery.min.js:2 render.js?v=20230410094859:155 Uncaught TypeError: marked is not a function at Object.render_markdown (render.js?v=20230410094859:155) at Object.success (main.js?v=20230410094859:582) at c (jquery.min.js:2) at Object.fireWith [as resolveWith] (jquery.min.js:2) at l (jquery.min.js:2) at XMLHttpRequest.<anonymous> (jquery.min.js:2)

paulhybryant commented 1 year ago

Yes, it is not just for zenmode. I didn't event have zenmode enabled. All the markdown description of the plugins have a blank description.

echarles commented 1 year ago

I have opened https://github.com/Jupyter-contrib/jupyter_nbextensions_configurator/pull/154 that fixes the markdown description. However, zenmode (and potentially others) should be fixed upstream.

echarles commented 1 year ago

https://github.com/Jupyter-contrib/jupyter_nbextensions_configurator/pull/154 is merged.

Next step is to cut a new release. @juhasch could you help with that?

echarles commented 1 year ago

@juhasch We need your help for a new release.

paulhybryant commented 1 year ago

Is there a new release? Thanks!

echarles commented 1 year ago

@paulhybryant Yes, you can pip instlall jupyter-nbextensions-configurator==0.6.3

https://pypi.org/project/jupyter-nbextensions-configurator/0.6.3