search

Jupyter-contrib / jupyter_nbextensions_configurator

A jupyter notebook serverextension providing config interfaces for nbextensions.
Other
981 stars 121 forks source link

Update import for backwards compatibility #169

Open RRosio opened 1 year ago

RRosio commented 1 year ago

JupyterServer handlers are not compatible with Notebook 6 series, this updates mitigates error that Notebook 6 users installing the latest version of the jupyter_nbextensions_configurator, may encounter.

xyepeng commented 1 year ago

I think your solution can solve my problem, but can you explain the specific steps? I am a novice

RRosio commented 1 year ago

Hi @xyepeng, this is an update that will help jupyter_nbextensions_configurator work with both Notebook 6 and Notebook 7. The current main branch has some merged updates that haven't been released yet and this is a small follow up to those changes. Notebook 7 has a different codebase than Notebook 6, where Notebook 6 has its own handlers, in Notebook 7 we want the handlers to be imported from jupyter_server package. In this PR I am making sure we first check if the handlers can be imported from the notebook module (Notebook 6), otherwise we have Notebook 7 and we need to import from jupyter_server

strelok372 commented 1 year ago

Hi! I suppose, this PR should fix 'No module named 'notebook.base'' problem? If yes, maybe could you explain how to install nbextension with your fix manually? I'd like to test it and have already downloaded it

RRosio commented 11 months ago

Hi @strelok372, apologies for the delay in my reply. Yes, this is the issue that this PR addresses. The import statement is being updated so that in the case that importing the modules/functionality requested from the notebook fails, then they are instead requested from jupyter_server. This is because Notebook 7 is a different codebase than Notebook 6, and those imports are not present in the Notebook 7 codebase but rather the JupyterServer codebase. You can try modifying those imports and installing a local version of this package. I am blocked on another issue that comes up with a different packagejupyter_contrib_core: https://github.com/Jupyter-contrib/jupyter_contrib_core/pull/15. Those changes may also be necessary to make locally! If you can clone this repository and either apply the changes or checkout them out, then pip install -e . you will be able to try these changes!