JurajNyiri / HomeAssistant-Tapo-Control

Control for Tapo cameras as a Home Assistant component
Apache License 2.0
1.08k stars 85 forks source link

Update to 2023.5.2 causes ONVIF error #337

Closed johnjoemorgan closed 1 year ago

johnjoemorgan commented 1 year ago

Description

Home Assistant 2023.5.2 Supervisor 2023.04.1 Operating System 10.1 Frontend 20230503.3 - latest

Logger: homeassistant.setup Source: setup.py:214 First occurred: 12:37:45 (1 occurrences) Last logged: 12:37:45 Setup failed for custom integration tapo_control: Unable to import component: cannot import name 'retry_connection_error' from 'onvif.client' (/usr/local/lib/python3.10/site-packages/onvif/client.py)

Reproduction Steps

Service does not run on start up

Expected behavior

Start runs on start up

If applicable, add error logs.

Logger: homeassistant.setup Source: setup.py:214 First occurred: 12:37:45 (1 occurrences) Last logged: 12:37:45 Setup failed for custom integration tapo_control: Unable to import component: cannot import name 'retry_connection_error' from 'onvif.client' (/usr/local/lib/python3.10/site-packages/onvif/client.py)

Device Firmware

1.3.6

Using stream component

Yes

Does camera work via official integrations?

No

Camera has all attributes filled out in developer tools

Yes

HASS Environment

Supervisor

Search for similar issues

Yes

Additional information

Update included ONVIF updates:

https://github.com/home-assistant/core/pull/92627

https://github.com/home-assistant/core/pull/92629

https://github.com/home-assistant/core/pull/92350

JurajNyiri commented 1 year ago

Update to latest version before reporting an issue.

johnjoemorgan commented 1 year ago

OK ... I would of if it was available to me at the time of reporting. I see updates have now pushed through. Thanks

JurajNyiri commented 1 year ago

5.2.0 was published 11 hours ago. Glad you got it working.