JurajNyiri / HomeAssistant-Tapo-Control

Control for Tapo cameras as a Home Assistant component
Apache License 2.0
1.13k stars 89 forks source link

Bug: Services Enable/Disable Motion Detection inverted #38

Closed rodrigogbs closed 3 years ago

rodrigogbs commented 3 years ago

Describe the bug The services "camera.enable_motion_detection" and "camera.disable_motion_detection" are inverted, when calling "camera.enable_motion_detection" the motion detection turns OFF, and when calling "camera.disable_motion_detection" the motion detection turns ON.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Developer Tools -> Services'
  2. Run service 'camera.enable_motion_detection' with parameters 'name of your camera'
  3. See that motion_detection was turned OFF
  4. Run service 'camera.disable_motion_detection' with parameters 'name of your camera'
  5. See that motion_detection was turned ON

Expected behavior When calling "camera.enable_motion_detection" the motion detection must turn ON, and when calling "camera.disable_motion_detection" the motion detection must turn OFF.

Log Not applicable.

Camera (please complete the following information):

Using stream component [no]

Camera works through onvif component OR different cameras work in general [yes]

Camera has all attributes filled out properly in developer tools [yes]

HASS Environment [default HASSIO on a raspberry pi4]

Additional context Not applicable.

vks007 commented 3 years ago

yep, I too noticed this.

JurajNyiri commented 3 years ago

Thank you for the bug report, fixed in 2.2.2.

vks007 commented 3 years ago

Thanks, it works fine now.

rodrigogbs commented 3 years ago

Now it’s working well, thanks!