search

Juris-M / citeproc-js-docs

Documentation for citeproc-js
13 stars 14 forks source link

Correct makeBibliography() documentation #24

Open outboundexplorer opened 5 years ago

outboundexplorer commented 5 years ago

entry_ids is an array of arrays

fbennett commented 5 years ago

That looks odd, doesn't it. I wonder if this was even by intention. I'll double-check that it's doing that, then take your commit.

outboundexplorer commented 5 years ago

That’s what I figured. I’m not ready to look deeper into the code at the moment. Although, my gut feeling is that there is no need for these to be returned as an array.

On 16 Apr 2019, at 10:44, Frank Bennett notifications@github.com<mailto:notifications@github.com> wrote:

That looks odd, doesn't it. I wonder if this was even by intention. I'll double-check that it's doing that, then take your commit.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FJuris-M%2Fciteproc-js-docs%2Fpull%2F24%23issuecomment-483589338&data=02%7C01%7C%7Cff4db2de525e45516c9408d6c2501de5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636910046680760729&sdata=HKd%2F5JixgXIKsyWiitgYMe5NBPxycAuKu91gFpzix0k%3D&reserved=0, or mute the threadhttps://nam03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGctaMQCaETHq9qZyoHYs4rVhA1-3LVrks5vhZt5gaJpZM4cxxi3&data=02%7C01%7C%7Cff4db2de525e45516c9408d6c2501de5%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636910046680770737&sdata=sVOSJcRH22h50mM8e9XazKsHgmjlZE0PBVHwLSBNAvQ%3D&reserved=0.