dsifford
commented
8 years ago Awesome, glad you like the new syntax! Of note, if you think ES6 classes are nice, you should REALLY check out TypeScript... For me, the step from ES5 to ES6 felt the same as the step from ES6 to TypeScript (if we're measuring on the, "holy cow, this is really nice" scale). (Especially if you use atom-typescript).
Ok, phew, ending sales pitch...
Looks good so far. One thing I've never seen before that you're using is this. Is that a legal syntax move? If so, I'm totally jealous on how fast you can go from beginner-to-awesome when learning new syntaxes. Where can I read more about that?
If all you're trying to do is create a class that others can extend (ie "hook into"), all you'd need to do is just create a class normally and export it...
// file1.js
export class MyClass {
constructor(num) {
this.num = num;
}
}
// file2
import { MyClass } from './file1.js';
class AnotherClass extends MyClass {
constructor(num, str) {
super(num); // <-- important
this.str = str;
}
}
So, in a nutshell, all of the methods and properties from MyClass are available on AnotherClass plus whatever the user wants to add in.
The only other tiny thing I'll mention (which is mostly just a preference): Ditch the use of var. If you need a variable that re-assignable, use let. If you need a variable that isn't, use const.
One common misconception that new ES6 users have is that const behaves like an immutable variable. That's false. You just can't reassign it. So both of these are legal...
const arr = [];
arr.push(1);
arr.push(2);
console.log(arr);
// [1, 2]
arr = 2;
// illegal
const obj = {
foo: 'bar',
};
obj['bar'] = 'baz';
console.log(obj);
// Object {foo: "bar", bar: "baz"}
obj = [1,2];
// illegalHopefully that helps! Let me know if there's anything else I can help with. Awesome work so far!
fbennett
@dsifford Thanks to your framework in citesupport-es6.js, I'm learning how JS classes work (and much the happier for it).
It might save you some time if I go ahead and rewrite the demo using class syntax. Take a look at the code layout -- I've set it up to use a class for the main code, mixed in with hook functions specific to the raw DOM environment, and extended with an init function that is specific to the demo.
The idea is to give you a core logic-only module that you can extend with the hook functions to speak with documents in specific projects. Does it look like this layout will do that?