Juris-M / citeproc-js

A JavaScript implementation of the Citation Style Language (CSL) https://citeproc-js.readthedocs.io
Other
307 stars 85 forks source link

TypeError: Cannot read property 'before' of undefined #28

Closed adam3smith closed 7 years ago

adam3smith commented 7 years ago

When I run citeproc-js with node.js for the cslEditor, it throws the above error for a subset of styles, e.g. ambio.csl

This is starting at version 1.1.142 and is true for all versions since. 1.1.141 works fine

Any thoughts?

fbennett commented 7 years ago

Able to reproduce this - and it looks like a crashing bug for production instances too. Ouch! Will get to work on a fix pronto.

fbennett commented 7 years ago

A variable name was misspelled. Fix pushed, will be available via Propachi soon.

adam3smith commented 7 years ago

Thanks -- haven't tested this yet, but glad those 40,000+ citations I calculate every time I update the editor actually helped catch a bug.

fbennett commented 7 years ago

They certainly saved a world of consternation on this occasion - literally.