Juris-M / citeproc-test-runner

5 stars 5 forks source link

Not parsing csl-m schema #10

Closed georgd closed 4 years ago

georgd commented 4 years ago

Somehow, citeproc-test-runner isn’t picking up the csl-m schema any more when run on csl-m styles and I get lots of validation errors:

cslrun -w ~/Zotero/styles/jm-indigobook.csl -a -k

will return

Using processor from package
Watching: /Users/gduffner/Zotero/styles/jm-indigobook.csl
Validating CSL.
[472] : error: value of attribute "match" is invalid; must be equal to "all", "any" or "none"
[474] : error: value of attribute "match" is invalid; must be equal to "all", "any" or "none"
[494] : error: value of attribute "match" is invalid; must be equal to "all", "any" or "none"
[496] : error: value of attribute "match" is invalid; must be equal to "all", "any" or "none"
[737] : error: value of attribute "match" is invalid; must be equal to "all", "any" or "none"
[739] : error: value of attribute "match" is invalid; must be equal to "all", "any" or "none"
[1014] : error: value of attribute "variable" is invalid; must be equal to "DOI", "ISBN", "ISSN", "PMCID", "PMID", "URL", "abstract", "admin-flag", "alt-container-title", "alt-title", "annote", "archive", "archive-place", "archive_location", "citation-label", "citation-number", "collection-title", "container-title", "container-title-short", "country", "dimensions", "document-name", "event", "event-place", "first-reference-note-number", "gazette-flag", "genre", "hereinafter", "jurisdiction", "keyword", "language-name", "language-name-original", "locator", "medium", "note", "original-publisher", "original-publisher-place", "original-title", "publisher", "publisher-place", "references", "reviewed-title", "scale", "section", "source", "status", "title", "title-main", "title-short", "title-sub", "version", "volume-title" or "year-suffix"
[1274] : error: attribute "is-parallel" not allowed here; expected attribute "display", "font-style", "font-variant", "font-weight", "layout-delimiter-override", "parallel-delimiter-override", "parallel-first", "parallel-last", "parallel-last-override", "parallel-last-to-first", "prefix", "quotes", "reject", "require", "subgroup-delimiter", "subgroup-delimiter-precedes-last", "suffix", "text-decoration" or "vertical-align"
[1279] : error: attribute "is-parallel" not allowed here; expected attribute "display", "font-style", "font-variant", "font-weight", "layout-delimiter-override", "parallel-delimiter-override", "parallel-first", "parallel-last", "parallel-last-override", "parallel-last-to-first", "prefix", "quotes", "reject", "require", "subgroup-delimiter", "subgroup-delimiter-precedes-last", "suffix", "text-decoration" or "vertical-align"
[1802] : error: value of attribute "match" is invalid; must be equal to "all", "any" or "none"

Validation failure for style_test001

I’m on citeproc-test-runner 1.1.70.

fbennett commented 4 years ago

Not seeing that here. Are the paths set correctly in your ~/.cslrun.yaml file?

georgd commented 4 years ago

I'm not setting a schema path there. Where does the program look for the schema by default?

Frank Bennett notifications@github.com schrieb am So., 12. Juli 2020, 15:04:

Not seeing that here. Are the paths set correctly in your ~/.cslrun.yaml file?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Juris-M/citeproc-test-runner/issues/10#issuecomment-657219202, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABUH4VSUH3TGUDHXQ3Y7FLR3GYEZANCNFSM4OXXG5VQ .

fbennett commented 4 years ago

It's bundled. If you can find the installed code, what do you see in node_modules/citeproc-csl-schema!?

On Sunday, July 12, 2020, Georg Mayr-Duffner notifications@github.com wrote:

I'm not setting a schema path there. Where does the program look for the schema by default?

Frank Bennett notifications@github.com schrieb am So., 12. Juli 2020, 15:04:

Not seeing that here. Are the paths set correctly in your ~/.cslrun.yaml file?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Juris-M/citeproc-test-runner/issues/ 10#issuecomment-657219202, or unsubscribe https://github.com/notifications/unsubscribe-auth/ AABUH4VSUH3TGUDHXQ3Y7FLR3GYEZANCNFSM4OXXG5VQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Juris-M/citeproc-test-runner/issues/10#issuecomment-657223904, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASMSTTT4WBOZM2AXSDHLDR3G457ANCNFSM4OXXG5VQ .

georgd commented 4 years ago

Funny things I see. It‘s some time warpy thing happening there. Most of the files bear 26 October 1986 as modification date (related to https://github.com/npm/npm/issues/20439 ?). I can find the incriminated locator-extra variable in the file csl-mlz.rnc (the invalid match attribute is nand which indeed doesn’t exist any longer).

georgd commented 4 years ago

I could fix it by updating jm-indigobook manually. The new version has the same updated time so it’s not picked up automatically?

fbennett commented 4 years ago

Where are you fetching the file from?

On Monday, July 13, 2020, Georg Mayr-Duffner notifications@github.com wrote:

I could fix it by updating jm-indigobook manually. The new version has the same updated time so it’s not picked up automatically?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Juris-M/citeproc-test-runner/issues/10#issuecomment-657436955, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASMSV4GGIJ32NIR6U3IGLR3LG5XANCNFSM4OXXG5VQ .

georgd commented 4 years ago

I thought it would update automatically like Zotero styles do. I fetched the current version from GitHub.

Frank Bennett notifications@github.com schrieb am Mo., 13. Juli 2020, 11:58:

Where are you fetching the file from?

On Monday, July 13, 2020, Georg Mayr-Duffner notifications@github.com wrote:

I could fix it by updating jm-indigobook manually. The new version has the same updated time so it’s not picked up automatically?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/Juris-M/citeproc-test-runner/issues/10#issuecomment-657436955 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAASMSV4GGIJ32NIR6U3IGLR3LG5XANCNFSM4OXXG5VQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Juris-M/citeproc-test-runner/issues/10#issuecomment-657458680, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABUH4S3ESI2LSDV4KP2MJLR3LLDPANCNFSM4OXXG5VQ .

fbennett commented 4 years ago

The style does not update when the client is updated?

On Monday, July 13, 2020, Georg Mayr-Duffner notifications@github.com wrote:

I thought it would update automatically like Zotero styles do. I fetched the current version from GitHub.

Frank Bennett notifications@github.com schrieb am Mo., 13. Juli 2020, 11:58:

Where are you fetching the file from?

On Monday, July 13, 2020, Georg Mayr-Duffner notifications@github.com wrote:

I could fix it by updating jm-indigobook manually. The new version has the same updated time so it’s not picked up automatically?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/Juris-M/citeproc-test-runner/issues/ 10#issuecomment-657436955 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ AAASMSV4GGIJ32NIR6U3IGLR3LG5XANCNFSM4OXXG5VQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Juris-M/citeproc-test-runner/issues/ 10#issuecomment-657458680, or unsubscribe https://github.com/notifications/unsubscribe-auth/ AABUH4S3ESI2LSDV4KP2MJLR3LLDPANCNFSM4OXXG5VQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Juris-M/citeproc-test-runner/issues/10#issuecomment-657461265, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASMSSM6KWQ2KX55K2CUXDR3LLSFANCNFSM4OXXG5VQ .

georgd commented 4 years ago

No, it hasn’t updated.

Am Mo., 13. Juli 2020 um 12:16 Uhr schrieb Frank Bennett < notifications@github.com>:

The style does not update when the client is updated?

On Monday, July 13, 2020, Georg Mayr-Duffner notifications@github.com wrote:

I thought it would update automatically like Zotero styles do. I fetched the current version from GitHub.

Frank Bennett notifications@github.com schrieb am Mo., 13. Juli 2020, 11:58:

Where are you fetching the file from?

On Monday, July 13, 2020, Georg Mayr-Duffner <notifications@github.com

wrote:

I could fix it by updating jm-indigobook manually. The new version has the same updated time so it’s not picked up automatically?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/Juris-M/citeproc-test-runner/issues/ 10#issuecomment-657436955 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ AAASMSV4GGIJ32NIR6U3IGLR3LG5XANCNFSM4OXXG5VQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Juris-M/citeproc-test-runner/issues/ 10#issuecomment-657458680, or unsubscribe https://github.com/notifications/unsubscribe-auth/ AABUH4S3ESI2LSDV4KP2MJLR3LLDPANCNFSM4OXXG5VQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/Juris-M/citeproc-test-runner/issues/10#issuecomment-657461265 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAASMSSM6KWQ2KX55K2CUXDR3LLSFANCNFSM4OXXG5VQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Juris-M/citeproc-test-runner/issues/10#issuecomment-657469534, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABUH4XHZSIDVMQ37N24IY3R3LNGLANCNFSM4OXXG5VQ .

fbennett commented 4 years ago

Maybe the date is relevant then I'll check the code. I plan to implement over-the- wire updates like Zotero but, you know, time.

On Monday, July 13, 2020, Georg Mayr-Duffner notifications@github.com wrote:

No, it hasn’t updated.

Am Mo., 13. Juli 2020 um 12:16 Uhr schrieb Frank Bennett < notifications@github.com>:

The style does not update when the client is updated?

On Monday, July 13, 2020, Georg Mayr-Duffner notifications@github.com wrote:

I thought it would update automatically like Zotero styles do. I fetched the current version from GitHub.

Frank Bennett notifications@github.com schrieb am Mo., 13. Juli 2020, 11:58:

Where are you fetching the file from?

On Monday, July 13, 2020, Georg Mayr-Duffner < notifications@github.com

wrote:

I could fix it by updating jm-indigobook manually. The new version has the same updated time so it’s not picked up automatically?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/Juris-M/citeproc-test-runner/issues/ 10#issuecomment-657436955 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ AAASMSV4GGIJ32NIR6U3IGLR3LG5XANCNFSM4OXXG5VQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Juris-M/citeproc-test-runner/issues/ 10#issuecomment-657458680, or unsubscribe https://github.com/notifications/unsubscribe-auth/ AABUH4S3ESI2LSDV4KP2MJLR3LLDPANCNFSM4OXXG5VQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/Juris-M/citeproc-test-runner/issues/ 10#issuecomment-657461265 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ AAASMSSM6KWQ2KX55K2CUXDR3LLSFANCNFSM4OXXG5VQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Juris-M/citeproc-test-runner/issues/ 10#issuecomment-657469534, or unsubscribe https://github.com/notifications/unsubscribe-auth/ AABUH4XHZSIDVMQ37N24IY3R3LNGLANCNFSM4OXXG5VQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Juris-M/citeproc-test-runner/issues/10#issuecomment-657472021, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASMSWHPM2NX3XWKHP33FLR3LNXXANCNFSM4OXXG5VQ .

fbennett commented 4 years ago

Just to be sure, your Jurism is at version 5.0.89m9?

On Monday, July 13, 2020, Georg Mayr-Duffner notifications@github.com wrote:

No, it hasn’t updated.

Am Mo., 13. Juli 2020 um 12:16 Uhr schrieb Frank Bennett < notifications@github.com>:

The style does not update when the client is updated?

On Monday, July 13, 2020, Georg Mayr-Duffner notifications@github.com wrote:

I thought it would update automatically like Zotero styles do. I fetched the current version from GitHub.

Frank Bennett notifications@github.com schrieb am Mo., 13. Juli 2020, 11:58:

Where are you fetching the file from?

On Monday, July 13, 2020, Georg Mayr-Duffner < notifications@github.com

wrote:

I could fix it by updating jm-indigobook manually. The new version has the same updated time so it’s not picked up automatically?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/Juris-M/citeproc-test-runner/issues/ 10#issuecomment-657436955 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ AAASMSV4GGIJ32NIR6U3IGLR3LG5XANCNFSM4OXXG5VQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Juris-M/citeproc-test-runner/issues/ 10#issuecomment-657458680, or unsubscribe https://github.com/notifications/unsubscribe-auth/ AABUH4S3ESI2LSDV4KP2MJLR3LLDPANCNFSM4OXXG5VQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/Juris-M/citeproc-test-runner/issues/ 10#issuecomment-657461265 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ AAASMSSM6KWQ2KX55K2CUXDR3LLSFANCNFSM4OXXG5VQ

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Juris-M/citeproc-test-runner/issues/ 10#issuecomment-657469534, or unsubscribe https://github.com/notifications/unsubscribe-auth/ AABUH4XHZSIDVMQ37N24IY3R3LNGLANCNFSM4OXXG5VQ .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Juris-M/citeproc-test-runner/issues/10#issuecomment-657472021, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASMSWHPM2NX3XWKHP33FLR3LNXXANCNFSM4OXXG5VQ .

georgd commented 4 years ago

[...] but, you know, time.

I feel with you :)

Just to be sure, your Jurism is at version 5.0.89m9?

Ok, it was m8, updated 3 days ago. I‘m updating now.

georgd commented 4 years ago

The original issue is fixed so this could be closed.

fbennett commented 4 years ago

@georgd: Just realized that if you're on Windows, m9 is still pending. Other work intervened, and I didn't quite finish the release. Coming up soon ...

georgd commented 4 years ago

Haven’t tested on the Windows machine yet, only on the Mac so I didn't notice :)