Juris-M / juris-m.github.io

7 stars 4 forks source link

Validator (Editor). Wrongly gives error for `summary` element when child of `info`. #97

Open JohnLukeBentley opened 6 years ago

JohnLukeBentley commented 6 years ago

To reproduce:

Line 15: Element “summary” from namespace “http://purl.org/net/xbiblio/csl” not allowed as child of element “info” from namespace “http://purl.org/net/xbiblio/csl” in this context. (Suppressing further errors from this subtree.)

However, summary is permitted as a child of info. This is demonstrated in the example in the "Getting Started" section of https://juris-m.github.io/editor/ (as well as being in the spec http://docs.citationstyles.org/en/stable/specification.html)

Continue the test ...

The *.csl file appears to the validator as otherwise OK.

Continue the test ...

It seems that the Validator doesn't like the summary element, but only in some circumstances which my jlb-jm-indigobook.csl triggers.

Maybe the Validator is choking on my comments? Search for <!-- JLB Start -->. Or perhaps the particulars of the text in my summary

Modifies JM Indigo Book by outputing ISO 8601 date formats. E.g. "2018-03-24".

??

Tested in Firefox 59.0.2

Edit: " appears the validator" to "appears to the validator"; "chocking" to "choking"; markup for formatting consistency.

fbennett commented 6 years ago

If I understand correctly, you are bumping up against additional formatting conditions imposed by the CSL maintainers, which I've included in the validator. Consistency is important to them, because of the volume of styles that they review.

Will take a closer look at your comments later, to be sure I'm not missing the point.

On Sat, Mar 31, 2018, 12:51 John Luke Bentley notifications@github.com wrote:

To reproduce:

Line 15: Element “summary” from namespace “ http://purl.org/net/xbiblio/csl” not allowed as child of element “info” from namespace “http://purl.org/net/xbiblio/csl” in this context. (Suppressing further errors from this subtree.)

However, summary is permitted as a child of info. This is demonstrated in the example in the "Getting Started" section of https://juris-m.github.io/editor/ (as well as being in the spec http://docs.citationstyles.org/en/stable/specification.html)

Continue the test ...

  • In your local copy of jlb-jm-indigobook.csl remove the summary element (the whole line).
  • Reupload to the Validator and Load.
  • Observe "Success and welcome".

The *.csl file appears the validator as otherwise OK.

Continue the test ...

  • Load/validate a local default copy of jm-harvard-australian-national-university.csl
  • Observe this passes even though it has a summary child element of info.

It seems that the Validator doesn't like the summary element, but only in some circumstances which my jlb-jm-indigobook.csl triggers.

Maybe the Validator is chocking on my comments? Search for . Or perhaps the particulars of the text in my summary

Modifies JM Indigo Book by outputing ISO 8601 date formats. E.g. "2018-03-24".

??

Tested in Firefox 59.0.2

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Juris-M/juris-m.github.io/issues/97, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEmSofaoSvX2Uv59x5zvBPHl2iFwosEks5tjv05gaJpZM4TCUZK .