search

Juris-M / zotero-odf-scan-plugin

RTF/ODF-Scan for Zotero add-on
https://zotero-odf-scan.github.io/zotero-odf-scan/
Other
87 stars 14 forks source link

Hyperlink Version Breaks ODF File #29

Open paultroop opened 5 years ago

paultroop commented 5 years ago

I'm hoping that this issue can be looked at again as it's a truly useful function. ODF scan provides an alternative hyperlink format that is exceptionally useful for looking up the cited source quickly (ie zotero://select/items/0_ABCDEFG). This used to work perfectly with ODF scan, but now corrupts the file. I have been converting to .txt format to avoid it, but it takes a lot of time and loses lots of my formatting. I'm happy to provided corrupted documents if somebody can assist.

fbennett commented 5 years ago

I've just given it a try, and the converted document throws an error on refresh. The error is thrown in the Abbrevs Filter, and it's due to a bug in very new code. How long has it been failing on you?

paultroop commented 5 years ago

I noticed it originally around November 2018 (see issue #21). I've been working around it since then, but it's just got too annoying.

fbennett commented 5 years ago

In that case, there must be another bug in there. Zotero have made some revisions around the select protocol, but I tested links with the old address format, and it still works. There must be something in ODF Scan itself that broke things. I have a Jurism release coming up tomorrow, and will include a fix for the threshold bug I found. Once that's out of the way we can work out what originally broke.

On Wed, Jun 5, 2019 at 8:14 PM Paul Troop notifications@github.com wrote:

I noticed it originally around November 2018 (see issue #21 https://github.com/Juris-M/zotero-odf-scan-plugin/issues/21). I've been working around it since then, but it's just got too annoying.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Juris-M/zotero-odf-scan-plugin/issues/29?email_source=notifications&email_token=AAASMSVRK7JT67Q5TTLIT6LPY6NZFA5CNFSM4HTTLWAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW7MLNI#issuecomment-499041717, or mute the thread https://github.com/notifications/unsubscribe-auth/AAASMSWGXQP4ZFFJSI3DERDPY6NZFANCNFSM4HTTLWAA .

paultroop commented 5 years ago

Thanks Frank. I've looked up a document that failed in November under the old system and can share it if that's useful?

fbennett commented 5 years ago

I'll try to break it myself first. If I (can't) get stuck, it might come in handy.

On Wed, Jun 5, 2019, 20:52 Paul Troop notifications@github.com wrote:

Thanks Frank. I've looked up a document that failed in November under the old system and can share it if that's useful?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Juris-M/zotero-odf-scan-plugin/issues/29?email_source=notifications&email_token=AAASMSWBZTDFAOX3KXPGH3TPY6SILA5CNFSM4HTTLWAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW7OYTY#issuecomment-499051599, or mute the thread https://github.com/notifications/unsubscribe-auth/AAASMST55MEC3PAWN6MNO43PY6SILANCNFSM4HTTLWAA .

paultroop commented 5 years ago

I'm not sure if anybody has had time to look at this, but I've found that switching off the 'recognise hyperlinks' option in Scrivener avoids the problem to some extent. I guess it must be the hyperlinks that are causing a problem?

bwiernik commented 4 years ago

See potential cause here: https://forums.zotero.org/discussion/29308/rtf-odf-scan-for-zotero#latest

paultroop commented 2 years ago

The original rationale for the reference with hyperlink was to also facilitate the use of the plugin for note taking / research. A scannable cite is used on the notes to provide a record of the original source. Not many people appreciate that it can be used in this way, but it provides a very useful functionality. The hyperlink allows one to quickly check back to the original source in case there is any doubt whether the notes or summary accurately reflect the source.