Updated translations don’t appear

Juris-M / zotero

Juris-M is a variant of the free and friendly Zotero research platform, with support for legal and multilingual materials.

https://juris-m.github.io

Other

75 stars 12 forks source link

Updated translations don’t appear #103

Closed georgd closed 3 years ago

georgd commented 3 years ago

After upgrading Juris-M to 5.0.93m5, the updated translations to chrome/locale/de/zotero/zotero.properties don’t show. Are localisations cached somewhere or were they simply not included in the latest release?

fbennett commented 3 years ago

It looks like I just screwed up and failed to push the code after merging your changes. Version 5.0.93m6 is now up for the Mac, will follow with Linux and Windows builds later (after dinner).

Frank

On Fri, Nov 27, 2020 at 4:35 PM Georg Mayr-Duffner notifications@github.com wrote:

After upgrading Juris-M to 5.0.93m5, the updated translations to chrome/locale/de/zotero/zotero.properties don’t show. Are localisations cached somewhere or were they simply not included in the latest release?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Juris-M/zotero/issues/103, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASMSUTOUDCHDR7IQUV6Y3SR5JCVANCNFSM4UESCAKQ .

fbennett commented 3 years ago

Linux and Windows are up as well. I checked, the new translations seem to be in place now. Thanks for the heads-up!

georgd commented 3 years ago

Thank you very much!

georgd commented 3 years ago

Hmm, I still don’t get the new translations. Neither on Windows nor on Mac.

georgd commented 3 years ago

@fbennett In https://github.com/Juris-M/zotero-schema/pull/3 you mention a script that shuffles data around. Could that be the culprit here?

fbennett commented 3 years ago

Just to be sure we're looking in the same place, could you send along a screenshot?

On Sat, Nov 28, 2020, 01:04 Georg Mayr-Duffner notifications@github.com wrote:

@fbennett https://github.com/fbennett In Juris-M/zotero-schema#3 https://github.com/Juris-M/zotero-schema/pull/3 you mention a script that shuffles data around. Could that be the culprit here?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Juris-M/zotero/issues/103#issuecomment-734898798, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASMSXDF7N24XESXZ5UHRLSR7EX3ANCNFSM4UESCAKQ .

georgd commented 3 years ago

Here, 'Legal Commentary' should read 'Gesetzeskommentar' and 'Book Abbrev' should read 'Buch-Kurztitel':

fbennett commented 3 years ago

Ah, sorry. I was living in the past. The client used to access locales from chrome/locale/xx-XX/zotero/, but they are now copied from there to resource/schema/global/schema.json (resource/schema/global/schema-jurism.json in Jurism) by the setup script at resource/schema/global/scripts/update-schema. As you suggested, that script (which in Jurism serves double-duty as the patch mechanism for Jurism extended fields) needed running before the build. The Mac build that just went live should give you the new field labels in the German locale.

georgd commented 3 years ago

Great, it’s there now :)

For future changes, should I still update translations in chrome/locale/xx-XX/zotero/ or anywhere else?

fbennett commented 3 years ago

Your changes were perfect. I just missed that step in preparing the releases.

On Sat, Nov 28, 2020, 22:22 Georg Mayr-Duffner notifications@github.com wrote:

Great, it’s there now :)

For future changes, should I still update translations in chrome/locale/xx-XX/zotero/ or anywhere else?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Juris-M/zotero/issues/103#issuecomment-735230648, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASMSXZ5DJDFSAU6DVY5UTSSD2SXANCNFSM4UESCAKQ .