search

Juris-M / zotero

Juris-M is a variant of the free and friendly Zotero research platform, with support for legal and multilingual materials.
https://juris-m.github.io
Other
77 stars 12 forks source link

Inheritable name options not working reliably #83

Closed georgd closed 4 years ago

georgd commented 4 years ago

While testing all the great new features with Jurism, I stumbled over this:

Both jm-legcit styles declare name-delimiter="/" but this is not applied in citations and bibliography when using Jurism. The macros look like this:

  <macro name="editor-short">
    <names variable="editor">
      <substitute>
        <names variable="collection-editor"/>
        <names variable="container-author"/>
      </substitute>
    </names>
  </macro>

I have to explicitly add <name delimiter="/"/>.

I now remember having seen this before with citeproc-test-runner as well, but only on the author name. That’s why the author macro was changed accordingly a while ago to work around this.

Is that desired behaviour in CSLm?

denismaier commented 4 years ago

Sidenote: I don't know if this particular case is desired in CSLm, but I've also had the impression before that inheritable attributes don't work reliably.

fbennett commented 4 years ago

It may take some time for me to get to this, unfortunately. Meanwhile, if you come up with a specific test that illustrates the failure, a pull request against the citeproc-js fixtures/local repo would be welcome.

On Tuesday, September 29, 2020, Georg Mayr-Duffner notifications@github.com wrote:

While testing all the great new features with Jurism, I stumbled over this:

Both jm-legcit styles declare name-delimiter="/" but this is not applied in citations and bibliography when using Jurism. The macros look like this:

I have to explicitly add .

I now remember having seen this before with citeproc-test-runner as well, but only on the author name. That’s why the author macro was changed accordingly a while ago to work around this.

Is that desired behaviour in CSLm?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Juris-M/zotero/issues/83, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASMSTXCUEYRRN4OVUFDYTSIDXUDANCNFSM4R46SSNA .

georgd commented 4 years ago

It may take some time for me to get to this, unfortunately.

It’s not a show-stopper as it’s quite simple to work around it.

Meanwhile, if you come up with a specific test that illustrates the failure, a pull request against the citeproc-js fixtures/local repo would be welcome.

I’ll do (tomorrow).

fbennett commented 4 years ago

The issue with name-delimiter has been fixed.