Juris-M ignores inheritable `name-delimiter`

[georgd]

citeproc-js ignored inheritable name-delimiter, so instead of the specified "/", the default ", "

This was fixed in citeproc-js with https://github.com/Juris-M/citeproc-js/commit/65d0efa95c9c22f3bd20817a211f08d7a6ad06f9 – nevertheless, when citing with Juris-M it resurfaces with legal_commentary. At least, book and article-journal behave correctly.

The screenshot from the bibliography shows the items from the tests chapCommentary_test014.txt (Schwimann/Kodek) and chapCommentary_test016.txt (Korinek/Holoubek) as well as book_test008.txt (Alker/Hölter) for comparison, cited using the style jm-leg-cit-rechtsquellenverzeichnis-literaturverzeichnis.csl.

[fbennett]

Thanks again. Will take a look soon.

On Friday, October 2, 2020, Georg Mayr-Duffner notifications@github.com wrote:

citeproc-js ignored inheritable name-delimiter, so instead of the specified "/", the default ", "

This was fixed in citeproc-js with Juris-M/citeproc-js@65d0efa https://github.com/Juris-M/citeproc-js/commit/65d0efa95c9c22f3bd20817a211f08d7a6ad06f9 – nevertheless, when citing with Juris-M it resurfaces with legal_commentary. At least, book and article-journal behave correctly.

The screenshot shows the items from the tests chapCommentary_test014.txt (Schwimann/Kodek) and chapCommentary_test016.txt (Korinek/Holoubek) as well as book_test008.txt (Alker/Hölter) for comparison, cited using the style jm-leg-cit-rechtsquellenverzeichnis-literaturverzeichnis.csl.

[image: image] https://user-images.githubusercontent.com/214002/94898897-9e26a080-0492-11eb-80d1-a163a738a5ba.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Juris-M/zotero/issues/86, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASMSVGFMTYW7BXUZRPWRTSIV775ANCNFSM4SBMAKPA .

[fbennett]

Fixed in citeproc-test-runner, and the fix for Jurism is processing now, will be up in a few minutes.

Hitting this was beneficial in revealing a bug in the way Jurism and the processor handle names. The test has a single name in the "family" field. That CSL-JSON imports to Jurism as a two-field name with a value only in the "lastName" subfield. When that is shipped back to the processor, Jurism is messily composing it with a value in "family", the same value again in "literal", and an empty string in "given". When the processor sees that, it handles it as an institution ... and institution delimiters were defaulting to ",".

The immediate fix was only to remove the default delimiter value from the cs:institution node that citeproc-js silently inserts into cs:names nodes. Then delimiter inheritance works properly, and the client renders things correctly. Whew!

[fbennett]

I overlooked a couple of things, one further update just went live. The latest test runner will validate against the randnummerterm, and the test runner and Jurism client now implement the country test.