Just-A-Tea-Drinker / OOP-Assement

Repo for the oop assement 1
0 stars 0 forks source link

Code Review from Edward Olley #2

Open Ed2003 opened 2 years ago

Ed2003 commented 2 years ago

Good Features The code runs efficiently and the exception handling works well. The code is also well laid out and is easy to understand. The code can also sort large amounts of manual text input. Features that need to be improved The file paths are too specific and is causing issues on other machines when the code is ran. Another issue that also needs to be resolved is that the code doesn't considers ellipses. This causes a problem as the code thinks that this is 3 different sentences when it should be recognised as one sentence. Another feature that could be implemented is a go back feature on the code which would make it more user friendly.

Just-A-Tea-Drinker commented 2 years ago

changes:

-The sentences differentiation has been added as well as things such as the usage of question marks and exclamation marks as these are all sentence ending denotations. -File paths have been altered in order to allow the code to run on a variety of machines or whoever downloads the code

-As for the going back feature I left this out, it would be nice however could be seen as unnecessary.