Just-A-Visitor / Algorithmic-Pseudocode

This repository contains the pseudocode(pdf) of various algorithms and data structures necessary for Interview Preparation and Competitive Coding
GNU General Public License v3.0
762 stars 167 forks source link

Pseudocode for First Non Repeating character in Stream #30

Closed stellarbeam closed 5 years ago

welcome[bot] commented 5 years ago

Thanks for opening this pull request! Please check out our contributing guidelines.

ghost commented 5 years ago

@helix026 I've written some reviews. Please check it out.

You can go through this and this code for more insights.

You can click on the Files Changed tab on the right to get an inline view on the comments.

ghost commented 5 years ago

Remember, the goal is to incorporate the entire algorithm in pseudocode and not just write it in plain English.

stellarbeam commented 5 years ago

I've made changes which you suggested. Please review.

ghost commented 5 years ago

@helix026 I have made a lot of changes. The new file can be found here. Make sure that you understand what those changes are (and learn the conventions of this repo in the process). Once you are satisfied with how to do things, Just update your file with my Gist (and resolve the conversation) and ping me. I'll then merge your PR.

welcome[bot] commented 5 years ago

Congrats on merging your first pull request! We here at behaviorbot are proud of you!

stellarbeam commented 5 years ago

Thank you so much for being so helpful and patient @Just-A-Visitor , this was my first time and I'm sure I've learnt a lot in the process. :smile:

ghost commented 5 years ago

https://github.com/Just-A-Visitor/Algorithmic-Pseudocode/issues/29

Well, Thank you for your contributions. Glad to have you here!