Quick Sort pseudocode. - Githubissues

Just-A-Visitor / Algorithmic-Pseudocode

This repository contains the pseudocode(pdf) of various algorithms and data structures necessary for Interview Preparation and Competitive Coding

GNU General Public License v3.0

762 stars 167 forks source link

Quick Sort pseudocode. #63

Closed j3r3mias closed 5 years ago

welcome[bot] commented 5 years ago

Thanks for opening this pull request! Please check out our contributing guidelines.

ghost commented 5 years ago

Welcome to the repository. Next time, before working on an issue, first create one and get it approved. Also, remember to go through the contributing guidelines.

I've suggested some changes. Please go through them.

Another important change

Swap the ordering of the functions Partition and Quicksort. (KeepPartition` on top).
Call Partition as a procedure and Quicksort as a function

j3r3mias commented 5 years ago

Hi, thanks for the insights. I did all the modifications suggested. Do I need to create a new PR?

ghost commented 5 years ago

No. You don't need to create a new PR. Please click on Resolve Conversation on all the comments.

ghost commented 5 years ago

I have suggested 4 more changes. Please go through them and resolve the conversation. Also, create a new issue and reference this pull request.

ghost commented 5 years ago

Good work! Thank you for your contribution to this repository. I hope you got to learn something new from this experience.

ghost commented 5 years ago

closes #69

welcome[bot] commented 5 years ago

Congrats on merging your first pull request! We here at behaviorbot are proud of you!