Just-Natsuki-Team / NatsukiModDev

The official repository of Team JN.
Other
84 stars 42 forks source link

Feature/enable remind no topic warning #710

Closed Blizzardsev closed 1 year ago

Blizzardsev commented 1 year ago

Introduces the following:

Closes #706

Blizzardsev commented 1 year ago

Worked as expected and I think it's a good addition in case people change their mind.

Not necessary, but maybe fun: Every time Natsuki tells the player they should not complain about it, might be nice to have one additional line in case the player immediately tells her to stop reminding again?

So as it stands, the reminder enable topic can't be seen multiple times - once the player asks her to remind them again, it is hidden until the player tells Nat not to remind them when she brings it up.

RaionArt commented 1 year ago

Yes, I'm aware! I was just talking about: -The player tells her to stop reminding. -She stops -The player asks her to start reminding again -Natsuki mentioned ok, but don't complain about it. -The player immediately tells her to stop at the first possibility again -Natsuki maybe has an extra line?

Blizzardsev commented 1 year ago

Yes, I'm aware! I was just talking about: -The player tells her to stop reminding. -She stops -The player asks her to start reminding again -Natsuki mentioned ok, but don't complain about it. -The player immediately tells her to stop at the first possibility again -Natsuki maybe has an extra line?

Ah okay, I'm following you now! Sure - I can look at adding that; the topic has a shown count I can use

Blizzardsev commented 1 year ago

@RaionArt What do you think?

RaionArt commented 1 year ago

Nice addition! I like how she seems a bit annoyed but tries to stay nice and friendly. This isn't locked on a time frame though, right? I'm worrying people might see this dialogue, when they maybe change their mind after a month for exmple. Is there a way so it doesn't sound too odd when Natsuki mentions "it wasn't that long ago" ?

Blizzardsev commented 1 year ago

Nice addition! I like how she seems a bit annoyed but tries to stay nice and friendly. This isn't locked on a time frame though, right? I'm worrying people might see this dialogue, when they maybe change their mind after a month for exmple. Is there a way so it doesn't sound too odd when Natsuki mentions "it wasn't that long ago" ?

Sure thing

RaionArt commented 1 year ago

Sorry for all the trouble, looks good to me now!