Just-Natsuki-Team / NatsukiModDev

The official repository of Team JN.
Other
84 stars 42 forks source link

Feature/blackjack #781

Closed Blizzardsev closed 10 months ago

Blizzardsev commented 1 year ago

Introduces the following:

Blizzardsev commented 1 year ago

@Just-Natsuki-Team/jn-reviewers This will need heavy testing due to the amount of content/mechanics in the new content being introduced, as well as a brief runthrough of Snap to make sure that all still functions as expected.

RaionArt commented 11 months ago

This will need more time to fully review, but some thoughts I already noticed:

When the option is enabled to show the hand total, it should show Nat's counts as well. Maybe something like "5+?" to show the hidden card as well. That would be easier for players who aren't too familiar with the rules of Blackjack or the value of the cards.

With the appearing text at the end of the round it might be nice to make a difference if Natsuki or the player busted for example. I know the notepad shows who won the last round, but still it feels a bit hectic with not an immediately clear way to see to whom the text is directed at. Possibilities could be different colors, different positions (Like Nat's text appear more on the top), or maybe something added to the text like "Nat busted". Again these are just some suggestions that came to mind, you can choose only one of them or maybe you have an entirely new idea how to handle it.

RaionArt commented 11 months ago

image In this case we hit a draw, but Nat reacted like she won. I feel like we already talked about this problem once already, but it seems like I already pulled the latest version

Blizzardsev commented 11 months ago

This will need more time to fully review, but some thoughts I already noticed:

When the option is enabled to show the hand total, it should show Nat's counts as well. Maybe something like "5+?" to show the hidden card as well. That would be easier for players who aren't too familiar with the rules of Blackjack or the value of the cards.

With the appearing text at the end of the round it might be nice to make a difference if Natsuki or the player busted for example. I know the notepad shows who won the last round, but still it feels a bit hectic with not an immediately clear way to see to whom the text is directed at. Possibilities could be different colors, different positions (Like Nat's text appear more on the top), or maybe something added to the text like "Nat busted". Again these are just some suggestions that came to mind, you can choose only one of them or maybe you have an entirely new idea how to handle it.

Sure, I can look at tweaking Nat's text for the hand total option - I agree through that we need to obfuscate the value of her first card still so there's some challenge involved.

With the round ending text, this was more of a placeholder: if possible I'd love to include some better designed graphics with some more flair to show off the result in a more clear/exciting way if time existed for that

Blizzardsev commented 11 months ago

image In this case we hit a draw, but Nat reacted like she won. I feel like we already talked about this problem once already, but it seems like I already pulled the latest version

Very odd, conditions should have handled this. I'll look into it

Blizzardsev commented 11 months ago

image In this case we hit a draw, but Nat reacted like she won. I feel like we already talked about this problem once already, but it seems like I already pulled the latest version

image

This has been added, but the notepaper labels for the names will need extending to reflect this so the text doesn't overrun.

The draw issue should be sorted too; it looks like the game was correctly calculating the round result but pulling the streak text incorrectly - this is because the win count for either player hadn't changed, and Nat won the round prior to the draw: and all the streak text was checking was if Nat had a win streak of 3, 5, etc.