Just-Natsuki-Team / NatsukiModDev

The official repository of Team JN.
Other
84 stars 42 forks source link

[ BUG REPORT ] - Rapid idle animations due to OpenWeatherMap API lag #854

Closed RZed01 closed 9 months ago

RZed01 commented 9 months ago

Overview:

If you have the Real-time weather feature on, there is a small chance that the API pinging the server to update the weather may cause a momentary freeze. During this freeze, the commands to change Natsuki's idle pose will continue to execute, so that by the time this check is finished, you may experience Natsuki briefly rapidly cycling through her idle poses before going back to normal behavior.

Replication steps:

This bug cannot be replicated consistently, since how long the bug lasts (and hence the rapid cycling of animations) is dependent on the connection lag between the home computer and the OpenWeatherMap server that the API will check.

Additional information:

Observed several times on Windows 10 22H2, non-insider preview build. In fact, it has occurred to me several times in the past few days. This is already a known issue that is actively being worked on, but since no report was filed, I am filing this myself for anyone who wants to take a shot at fixing this. I personally do not consider this as a fixable issue, but feel free to try and solve it.

RaionArt commented 9 months ago

Gotta close this as we are already aware and acknowledge this in #852. A fix is already in the works.

Blizzardsev commented 9 months ago

A (mostly complete, given Ren'Py limitations) fix for this has been found - it is however unrelated to weather functionality. In short, the way that Ren'Py handles transitions has the effect of speeding up the progression of images that make use of multiple choices, this including the idle displayable used for Natsuki. We therefore must apply a temporary static idle image while the transition takes place, before returning to the usual idle.

This has the side effect of the idle changing faster than expected once during the transition cycle, but much preferable to the rapid switching.

RZed01 commented 9 months ago

So this issue is related to #849 ? That's interesting.