search

Just-Some-Bots / MusicBot

:musical_note: The original MusicBot for Discord (formerly SexualRhinoceros/MusicBot)
https://just-some-bots.github.io/MusicBot/
MIT License
3.14k stars 2.36k forks source link

[Request - Help Wanted] Add Mixcloud support (play while downloading) #1227

Closed rdnt closed 3 years ago

rdnt commented 7 years ago

It would be nice to have Mixcloud support on the bot. Right now if someone tries to play a mixcloud mix the bot stops working and needs a restart.

MeepCastana commented 7 years ago

Don't think its that useful. Most of the songs you can find on youtube.

rdnt commented 7 years ago

Many DJs have weekly podcasts on their Mixcloud accounts and the tracks there are mixed together. Playlists have huge delay between songs. Also, Mixcloud includes live performances of many artists that you can't find on YouTube or SoundCloud. And many bots already incorporate Mixcloud support so I don't see a reason not to implement it.

MeepCastana commented 7 years ago

Oh well... this is the first time i hear about Mixcloud

rdnt commented 7 years ago

Update: Mixcloud seems to be actually working, though the whole track needs to be downloaded. It can't play otherwise. After waiting for the whole track to download you have to disconnect the bot and summon it and play. Investigating.

rdnt commented 7 years ago

Update 2: It is normal behavior to not start playing until the whole track is downloaded, but it seems mixcloud tracks download 4 megabytes and then stop. Restarting the bot and playing the same track downloads another 4 megabytes and so on...

rdnt commented 7 years ago

Update 3: This weird behavior is caused by Mixcloud throttling speeds after approximately 5 megabytes of continous download. This is intended so that a stream downloads while you're listening.

From the current implementation the bot waits for the track to finish downloading before playing.

If that could be changed so that the bot streamed the audio while it was being downloaded would solve the issue.

Tried with different download options and downloaders and the best-case scenario was to speed-download the first time and then restart the bot and play from there (it sees the file and thinks it's already downloaded and starts playing it).

Marking as [Help Wanted]

Aeilko commented 6 years ago

I think this issue can be closed. I use mixcloud with the bot a lot as well, and also experienced a lot of issues over the last year. But this is a youtube-dl problem, which is also currently fixed. Apparently mixcloud no longer throttles the download speed, or youtube-dl found a way around it. Larger mixes currently take about a minute to download on my system.

AutumnClove commented 3 years ago

Closing for inactivity