Just-Some-Bots / MusicBot

:musical_note: The original MusicBot for Discord (formerly SexualRhinoceros/MusicBot)
https://just-some-bots.github.io/MusicBot/
MIT License
3.14k stars 2.36k forks source link

Just a question #1538

Closed Geesmen closed 6 years ago

Geesmen commented 6 years ago

Please tick all applicable boxes.

Which version are you using?

What type of issue are you creating?


Description of issue

my bot auto skips when I'm no on voice chat, how can i stop it from skipping when im not on voice chat?

Steps to reproduce


Log file

Please attach your MusicBot log file (located at logs/musicbot.log) to this issue. You can do so by dragging and dropping the file here. If you do not include your log file, you WILL be asked to provide one.

AutumnClove commented 6 years ago

AutoPause=Yes in options.ini I believe should help with this, this will only work if no-one else is in the voice chat though.

MattBSG commented 6 years ago

See SkipWhenAbsent permissions.ini: https://github.com/Just-Some-Bots/MusicBot/blob/master/config/example_permissions.ini#L94

Geesmen commented 6 years ago

@AutumnClove u did that and didn't work

@MattBSG where is that link again? its not working

MattBSG commented 6 years ago

@Geesmen fixed my comment

Geesmen commented 6 years ago

@MattBSG I put my user id on that music master and put skipwhenabsent to no and it still skips when im not on voice chat.

amit177 commented 6 years ago

Please attach your permissions.ini and musicbot.log files.

Girard-Arnold commented 6 years ago

I'm running into the same issue currently, attaching my logs here if you don't mind :

musicbot.log permissions.txt

The IDs I put are roles IDs. originally I did not have any roles attributed to anyone. I have tried with both the option skipwhenabsent and without, it still behaves the same way.

DetectiveMecha commented 6 years ago

I am also running into the same issue. I would like to Queue a playlist for my users while I'm at work and the bot auto skips every song when I am not connected, despite being set up otherwise, and unless I managed to mess up a setting somewhere I don't really know what else to try.

musicbot.log permissions.txt

Note that my permissions.ini file isn't set as a TXT on my computer, I just couldn't figure out how else to upload it here, sorry.

mwallis45 commented 6 years ago

for both of you I would try remove = no and see if that does anything also Kurata-Saiaku this may not be a problem but your ID's are giving it to the role if this is ment to be like that then its ok but if it only ment to be two people then move it to userlist

DetectiveMecha commented 6 years ago

Sorry, that did not resolve the issue.

mwallis45 commented 6 years ago

please also make sure that UseExperimentalEqualization = no in options.ini as it does bug the player out sometimes.

Girard-Arnold commented 6 years ago

Did not solve my issues, unfortunately. The IDs are indeed roles IDs, not users IDs. I have tried to both set remove = no and remove = yes without any change. I removed UseExperimentalEqualization = yes since it made my bot bug by well, making it stop playing music suddenly.

Logs do not reveal anything about skipping.

mwallis45 commented 6 years ago

kurata-saiaku from your log it looks like the UseExperimentalEqualization option is still being used. If both of you could send the .last long when the bot next does the skip as that will have only that log in it and means that we can see what exactly is causing it to skip.

DetectiveMecha commented 6 years ago

Still having the issue, disabled the option you recommended

Here's my log musicbot.log

Girard-Arnold commented 6 years ago

musicbot.log Just did the test with one song, so this is a shorter logs output.

musicbot.log.last.log

MattBSG commented 6 years ago

@Kurata-Saiaku @DetectiveMecha are you both the owners (set in options.ini) for your bots? If so, does it skip for other people out of their channel with the permission to not skip?

DetectiveMecha commented 6 years ago

Created a Test Account on discord, seeing as my friends are all missing when I need them to test things, and gave it perms.

The test account does not have any issues.

Here is the log for that session.

musicbot.log

Sorry, as an edit and for clarification, yes, I am set as the bot's owner. I have tried both the auto setting, what it is set on now, and forcing it to have my idcode, which kind of worked.

Girard-Arnold commented 6 years ago

Confirmed, I am the owner and it skips only for me, not other users who are also musicmaster.

DetectiveMecha commented 6 years ago

Hey guys, I managed to find a way to fix this issue. I feel as though maybe it might be a kind of work around for right now, but it seems to work for me, so maybe it will work for anyone else with this issue.

In the permissions.py file, under the second Musicbot folder, editing with Notepad ++, you can navigate down slightly to find line 27, SkipWhenAbsent = True and change this value to False.

This has fixed the issue for me.

In future versions of the bot, setting this value to False by default might be recommended.

mwallis45 commented 6 years ago

@DetectiveMecha that was the very first fix but didn't work for geesmen or kurata-saiaku.

DetectiveMecha commented 6 years ago

I am aware that there are two separate permissions files that are involved in the Music Bot. The first one is labeled as an .ini, the second as a .py.

The one I modified to achieve results was the .py, under the actual bot files, and not just the one under the config folder.

Specifically, this line: https://github.com/Just-Some-Bots/MusicBot/blob/c0000fbd3fd14759a1a028a2b7a9d65974e6cbea/musicbot/permissions.py#L27

Girard-Arnold commented 6 years ago

Just found a weird behaviour again, When I queue a music while not being in the vocal room, it skips my song which is "normal", however if I join afterward and queue music again, it still tells me I'm not in the room. Will add logs this evening.

MattBSG commented 6 years ago

@DetectiveMecha Those values in permissions.py are default values. Changes in the config should override those.

Anyway, closing due to lack of activity